diff --git a/agb/src/agb_alloc/mod.rs b/agb/src/agb_alloc/mod.rs index 7fae40fe..53f3d5f8 100644 --- a/agb/src/agb_alloc/mod.rs +++ b/agb/src/agb_alloc/mod.rs @@ -13,7 +13,7 @@ unsafe impl Send for SendNonNull {} impl Clone for SendNonNull { fn clone(&self) -> Self { - SendNonNull(self.0) + *self } } impl Copy for SendNonNull {} diff --git a/agb/src/agbabi/mod.rs b/agb/src/agbabi/mod.rs index bfd4a385..a53823cf 100644 --- a/agb/src/agbabi/mod.rs +++ b/agb/src/agbabi/mod.rs @@ -154,7 +154,7 @@ mod test { #[test_case] fn test_all_of_memcpy(_gba: &mut Gba) { - let mut input = vec![0u8; 100]; + let mut input = [0u8; 100]; let mut output = vec![0u8; 100]; for size in 0..80 { diff --git a/agb/src/display/object/unmanaged/object.rs b/agb/src/display/object/unmanaged/object.rs index f1012a0e..98fc2a65 100644 --- a/agb/src/display/object/unmanaged/object.rs +++ b/agb/src/display/object/unmanaged/object.rs @@ -109,7 +109,7 @@ impl OamSlot<'_> { if let Some(affine_matrix) = &object.affine_matrix { Self::handle_affine(&mut attributes, frame_data, affine_matrix); } - attributes.write(unsafe { (OBJECT_ATTRIBUTE_MEMORY as *mut u16).add(self.slot * 4) }); + attributes.write(unsafe { OBJECT_ATTRIBUTE_MEMORY.add(self.slot * 4) }); frame_data.this_frame_sprites.push(object.sprite.clone()); } @@ -159,7 +159,7 @@ impl Drop for OamIterator<'_> { for idx in number_writen..*last_frame_written { unsafe { - let ptr = (OBJECT_ATTRIBUTE_MEMORY as *mut u16).add(idx * 4); + let ptr = OBJECT_ATTRIBUTE_MEMORY.add(idx * 4); ptr.write_volatile(0b10 << 8); } } diff --git a/agb/src/display/tiled/mod.rs b/agb/src/display/tiled/mod.rs index c04d812b..7248e380 100644 --- a/agb/src/display/tiled/mod.rs +++ b/agb/src/display/tiled/mod.rs @@ -189,7 +189,7 @@ impl TileSetting { } } -pub(self) fn find_screenblock_gap(screenblocks: &Bitarray<1>, gap: usize) -> usize { +fn find_screenblock_gap(screenblocks: &Bitarray<1>, gap: usize) -> usize { let mut candidate = 0; 'outer: while candidate < 16 - gap { diff --git a/examples/the-purple-night/src/lib.rs b/examples/the-purple-night/src/lib.rs index ea667825..754216df 100644 --- a/examples/the-purple-night/src/lib.rs +++ b/examples/the-purple-night/src/lib.rs @@ -1002,7 +1002,7 @@ impl SlimeData { entity.sprite.set_sprite(sprite); entity.velocity.x = match frame { - 2 | 3 | 4 => (Number::new(1) / 5) * Number::new(*direction as i32), + 2..=4 => (Number::new(1) / 5) * Number::new(*direction as i32), _ => 0.into(), };