alex/agb
1
0
Fork 0
mirror of https://github.com/italicsjenga/agb.git synced 2024-12-24 08:41:34 +11:00
Code Issues Packages Projects Releases Wiki Activity

Allow impl Into<Num<...>> to make it a bit simpler

Browse source
This commit is contained in:
Gwilym Kuiper 2022-07-12 12:53:17 +01:00
parent ead344ca0b
commit d78d9155bf
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
agb/src/sound/mixer/mod.rs
View file

@ -270,8 +270,8 @@ impl SoundChannel {
/// Note that this only works for mono sounds. Stereo sounds will not change /// Note that this only works for mono sounds. Stereo sounds will not change
/// how fast they play. /// how fast they play.
#[inline(always)] #[inline(always)]
pub fn playback(&mut self, playback_speed: Num<usize, 8>) -> &mut Self { pub fn playback(&mut self, playback_speed: impl Into<Num<usize, 8>>) -> &mut Self {
self.playback_speed = playback_speed; self.playback_speed = playback_speed.into();
self self
} }
@ -283,7 +283,9 @@ impl SoundChannel {
/// Defaults to 0 (meaning equal on left and right) and doesn't affect stereo /// Defaults to 0 (meaning equal on left and right) and doesn't affect stereo
/// sounds. /// sounds.
#[inline(always)] #[inline(always)]
pub fn panning(&mut self, panning: Num<i16, 4>) -> &mut Self { pub fn panning(&mut self, panning: impl Into<Num<i16, 4>>) -> &mut Self {
let panning = panning.into();
debug_assert!(panning >= Num::new(-1), "panning value must be >= -1"); debug_assert!(panning >= Num::new(-1), "panning value must be >= -1");
debug_assert!(panning <= Num::new(1), "panning value must be <= 1"); debug_assert!(panning <= Num::new(1), "panning value must be <= 1");
@ -296,7 +298,9 @@ impl SoundChannel {
/// ///
/// Must be a value >= 0 and defaults to 1. /// Must be a value >= 0 and defaults to 1.
#[inline(always)] #[inline(always)]
pub fn volume(&mut self, volume: Num<i16, 4>) -> &mut Self { pub fn volume(&mut self, volume: impl Into<Num<i16, 4>>) -> &mut Self {
let volume = volume.into();
assert!(volume >= Num::new(0), "volume must be >= 0"); assert!(volume >= Num::new(0), "volume must be >= 0");
self.volume = volume; self.volume = volume;