alex/agb
1
0
Fork 0
mirror of https://github.com/italicsjenga/agb.git synced 2024-12-23 00:01:34 +11:00
Code Issues Packages Projects Releases Wiki Activity

Add bounds check for panic writer (#645)

Browse source 
Can cause double panic by writing OOB.
- [x] no changelog update needed
This commit is contained in:
Corwin 2024-04-20 00:07:43 +01:00 committed by GitHub
parent 9fc52000fe e1a8b04616
commit e660d9257b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 5 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
agb/src/panics_render/text.rs
View file

@ -54,12 +54,11 @@ impl<'bitmap, 'gba> BitmapTextRender<'bitmap, 'gba> {
for y in 0..letter.height as usize {
for x in 0..letter.width as usize {
let rendered = letter.bit_absolute(x, y);
if rendered {
self.bitmap.draw_point(
x as i32 + self.head_position.x,
y as i32 + y_position_start,
self.colour,
);
let x = x as i32 + self.head_position.x;
let y = y as i32 + y_position_start;
if rendered && (0..=WIDTH).contains(&x) && (0..=HEIGHT).contains(&y) {
self.bitmap.draw_point(x, y, self.colour);
}
}
}