alex/anymap
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Reduce the work for rustc in the benchmarks.

Browse source 
This *does* mean that they no longer function as tests, which was
deliberate, but rustc is just too slow with the assertions in there as
well. If I care, I can make variants of it that actually test. For now,
I’m sufficiently happy with it.
This commit is contained in:
Chris Morgan 2016-06-11 13:28:30 +10:00
parent c52281b376
commit ec57ec49be
1 changed files with 6 additions and 23 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
src/lib.rs
View file

@ -293,6 +293,7 @@ impl<'a, A: ?Sized + UncheckedAnyExt, V: IntoBox<A>> VacantEntry<'a, A, V> {
mod bench { mod bench {
use AnyMap; use AnyMap;
use test::Bencher; use test::Bencher;
use test::black_box;
#[bench] #[bench]
fn insertion(b: &mut Bencher) { fn insertion(b: &mut Bencher) {
@ -331,43 +332,25 @@ mod bench {
#[bench] #[bench]
fn $name(b: &mut Bencher) { fn $name(b: &mut Bencher) {
$( $(
#[derive(Debug, PartialEq)]
struct $T(&'static str); struct $T(&'static str);
impl Default for $T {
fn default() -> $T {
$T(stringify!($T))
}
}
)* )*
b.iter(|| { b.iter(|| {
let mut data = AnyMap::new(); let mut data = AnyMap::new();
$( $(
assert_eq!(data.insert($T::default()), None::<$T>); let _ = black_box(data.insert($T(stringify!($T))));
)* )*
$( $(
assert_eq!(data.get(), Some(&$T::default())); let _ = black_box(data.get::<$T>());
)* )*
}) })
} }
); );
} }
// Pathalogical rustc/llvm case here. This takes *absurdly* long to compile (it adds something // Caution: if the macro does too much (e.g. assertions) this goes from being slow to being
// like 100 seconds), peaking at over 1GB of RAM (though -Z time-passes doesn’t pick up on // *really* slow (like add a minute for each assertion on it) and memory-hungry (like, adding
// that, as it’s in the middle of the “llvm modules passes [0]” that it happens and it’s all // several hundred megabytes to the peak for each assertion).
// freed at the end of that pass) and adding over 700KB to the final build. (3KB per type is
// more than I expected, reasonably or unreasonably.) TODO determine why and get it fixed.
//
// Selected rustc -Z time-passes output, with and without this block:
//
// - item-bodies checking: 0.4 seconds without, 5.2 seconds with;
// - borrow checking: 0.1 seconds without, 11 seconds with;
// - llvm module passes [0]: 2.5 seconds without, 49 seconds with;
// - codegen passes [0]: 0.6 seconds without, 11.2 seconds with.
//
// Very not good.
big_benchmarks! { big_benchmarks! {
insert_and_get_on_260_types, insert_and_get_on_260_types,
A0 B0 C0 D0 E0 F0 G0 H0 I0 J0 K0 L0 M0 N0 O0 P0 Q0 R0 S0 T0 U0 V0 W0 X0 Y0 Z0 A0 B0 C0 D0 E0 F0 G0 H0 I0 J0 K0 L0 M0 N0 O0 P0 Q0 R0 S0 T0 U0 V0 W0 X0 Y0 Z0