From 61d37734f81e6e7c07bb5ed632bd63d3f64a252f Mon Sep 17 00:00:00 2001 From: Marijn Suijten Date: Mon, 27 Dec 2021 11:43:12 +0100 Subject: [PATCH] ci: Run clippy once more without default features (#523) With more and more features being added to `ash`, now seems to be the right time to make sure the crate is clean of clippy warnings when building without any features in addition to building with the deafult set of features. --- .github/workflows/ci.yml | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d38ea1c..9aef254 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -76,7 +76,7 @@ jobs: profile: minimal toolchain: stable override: true - - run: rustup component add rustfmt + components: rustfmt - uses: actions-rs/cargo@v1 with: command: fmt @@ -92,12 +92,22 @@ jobs: profile: minimal toolchain: stable override: true - - run: rustup component add clippy + components: clippy - uses: actions-rs/cargo@v1 + name: Clippy lint without features with: command: clippy - args: -p ash --no-default-features -- -D warnings + # Only test the core ash and ash-window crate, where features reside. + # The examples crate would otherwise enable all default features again, + # making this test moot. + args: -p ash -p ash-window --no-default-features -- -D warnings - uses: actions-rs/cargo@v1 + name: Clippy lint with all features with: command: clippy args: --workspace --all-targets --all-features -- -D warnings + - uses: actions-rs/cargo@v1 + name: Clippy lint with default features + with: + command: clippy + args: --workspace --all-targets -- -D warnings