alex/ash
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

entry_libloading: Do not pass AsRef implementation by reference (#389)

Browse source 
All type parameters are implicitly bound by `Sized`; matching the `&`
out of `&str` implies that `str` must be bound by `Sized` which is not
true, resulting in:

    18 |         let entry = ash::Entry::with_library("foo")?;
       |                                              ^^^^^ doesn't have a size known at compile-time
       |
      ::: /home/marijn/Code/TraverseResearch/ash/ash/src/entry_libloading.rs:73:39
       |
    73 |     pub unsafe fn with_library(path: &impl AsRef<OsStr>) -> Result<Entry, LoadingError> {
       |                                       ----------------- required by this bound in `ash::entry_libloading::<impl EntryCustom<Arc<libloading::Library>>>::with_library`

After all `Library::new` accepts an `impl AsRef<OsStr>` without borrow,
which is what this function is modeled after to pass the same parameter
on directly.

Fixes: c6d5d66 ("entry_libloading: Provide Vulkan library loader from custom path (#319)")
This commit is contained in:
Marijn Suijten 2021-03-08 19:32:43 +01:00 • committed by GitHub
parent 9662364c8b
commit b3a010a315
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
ash/src/entry_libloading.rs
View file

@ -62,7 +62,7 @@ impl EntryCustom<Arc<Library>> {
/// # Ok(()) }
/// ```
pub unsafe fn new() -> Result<Entry, LoadingError> {
Self::with_library(&LIB_PATH)
Self::with_library(LIB_PATH)
}
/// Load Vulkan library at `path`
@ -70,7 +70,7 @@ impl EntryCustom<Arc<Library>> {
/// # Safety
/// `dlopen`ing native libraries is inherently unsafe. The safety guidelines
/// for [`Library::new`] and [`Library::get`] apply here.
pub unsafe fn with_library(path: &impl AsRef<OsStr>) -> Result<Entry, LoadingError> {
pub unsafe fn with_library(path: impl AsRef<OsStr>) -> Result<Entry, LoadingError> {
let lib = Library::new(path).map_err(LoadingError).map(Arc::new)?;
Ok(Self::new_custom(lib, |vk_lib, name| {