alex/ash
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

extensions/khr/device_group_creation: Take borrow of Entry in new() (#753)

Browse source 
Looks like #630 typo'd the argument for `DeviceGroupCreation::new()` by
unnecessarily requiring a move (`Clone`) of `Entry` just to call
`get_instance_proc_addr()` on it.  Replace this with a borrow to match
all other extensions.
This commit is contained in:
Marijn Suijten 2023-05-06 19:29:28 +02:00 committed by GitHub
parent 1374996499
commit d783af0f33
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Changelog.md
View file

@ -26,6 +26,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- `ExternalMemoryFd::get_memory_fd_properties()` - `ExternalMemoryFd::get_memory_fd_properties()`
- `ExternalMemoryWin32::get_memory_win32_handle_properties()` - `ExternalMemoryWin32::get_memory_win32_handle_properties()`
- `GetSurfaceCapabilities2::get_physical_device_surface_capabilities2()` - `GetSurfaceCapabilities2::get_physical_device_surface_capabilities2()`
- `VK_KHR_device_group_creation`: Take borrow of `Entry` in `fn new()` (#753)
### Removed ### Removed

2
ash/src/extensions/khr/device_group_creation.rs
View file

@ -13,7 +13,7 @@ pub struct DeviceGroupCreation {
} }
impl DeviceGroupCreation { impl DeviceGroupCreation {
pub fn new(entry: Entry, instance: &Instance) -> Self { pub fn new(entry: &Entry, instance: &Instance) -> Self {
let handle = instance.handle(); let handle = instance.handle();
let fp = vk::KhrDeviceGroupCreationFn::load(|name| unsafe { let fp = vk::KhrDeviceGroupCreationFn::load(|name| unsafe {
mem::transmute(entry.get_instance_proc_addr(handle, name.as_ptr())) mem::transmute(entry.get_instance_proc_addr(handle, name.as_ptr()))