alex/cacao
1
0
Fork 0
Code Issues Pull requests Packages Projects Releases Wiki Activity

Finalize some NSString handling that I'd been mulling over. This should be much more sound and transparent regarding ownership while keeping the same general approach that's been working so far.

Browse source
This commit is contained in:
Ryan McGrath 2020-03-31 20:59:08 -07:00
parent db4da24268
commit ab53150abc
No known key found for this signature in database
GPG key ID: 811674B62B666830
8 changed files with 76 additions and 58 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

44
examples/defaults.rs
View file

@ -4,7 +4,6 @@ use std::collections::HashMap;
use cacao::macos::{App, AppDelegate};
use cacao::defaults::{UserDefaults, Value};
use cacao::foundation::NSData;
#[derive(Default)]
struct DefaultsTest;
@ -15,30 +14,31 @@ impl AppDelegate for DefaultsTest {
defaults.register({
let mut map = HashMap::new();
//map.insert("LOL", Value::string("laugh"));
//map.insert("X", Value::Integer(1));
//map.insert("X2", Value::Float(1.0));
map.insert("BOOL", Value::Bool(false));
map.insert("testbool", Value::Bool(true));
map.insert("testint", Value::Integer(42));
map.insert("testfloat", Value::Float(42.));
map.insert("teststring", Value::string("Testing"));
let bytes = "BYTES TEST".to_string().into_bytes();
map.insert("testdata", Value::Data(bytes));
println!("Test equivalency:");
let s = "BYTES TEST".to_string().into_bytes();
println!(" {:?}", s);
let x = NSData::new(s);
println!(" {:?}", x.bytes());
let s2 = "BYTES TEST".to_string().into_bytes();
map.insert("BYTES", Value::Data(s2));
map
});
//println!("Retrieved LOL: {:?}", defaults.get("LOL"));
//println!("Retrieved LOL: {:?}", defaults.get("X"));
println!("Retrieved LOL: {:?}", defaults.get("BOOL"));
let testbool = defaults.get("testbool").unwrap().as_bool().unwrap();
assert_eq!(testbool, true);
let bytes = defaults.get("BYTES").unwrap();
println!("Bytes: {:?}", bytes);
let data = match std::str::from_utf8(bytes.as_data().unwrap()) {
let testint = defaults.get("testint").unwrap().as_i64().unwrap();
assert_eq!(testint, 42);
let testfloat = defaults.get("testfloat").unwrap().as_f64().unwrap();
assert_eq!(testfloat, 42.);
let teststring = defaults.get("teststring").unwrap();
assert_eq!(teststring.as_str().unwrap(), "Testing");
let bytes = defaults.get("testdata").unwrap();
let s = match std::str::from_utf8(bytes.as_data().unwrap()) {
Ok(s) => s,
Err(e) => {
eprintln!("Error converting bytes {}", e);
@ -46,8 +46,8 @@ impl AppDelegate for DefaultsTest {
}
};
println!("Retrieved Bytes: {}", data);
assert_eq!(s, "BYTES TEST");
println!("All UserDefaults tests pass");
App::terminate();
}

4
src/filesystem/manager.rs
View file

@ -56,10 +56,10 @@ impl FileManager {
create:NO
error:nil];
NSString::wrap(msg_send![dir, absoluteString]).to_str()
NSString::wrap(msg_send![dir, absoluteString])
};
Url::parse(directory).map_err(|e| e.into())
Url::parse(directory.to_str()).map_err(|e| e.into())
}
/// Given two paths, moves file (`from`) to the location specified in `to`. This can result in

54
src/foundation/string.rs
View file

@ -1,11 +1,3 @@
//! A wrapper library for `NSString`, which we use throughout the framework. This is abstracted out
//! for a few reasons, but namely:
//!
//! - It's used often, so we want a decent enough API.
//! - Playing around with performance for this type is ideal, as it's a lot of heap allocation.
//!
//! End users should never need to interact with this.
use std::{slice, str};
use std::os::raw::c_char;
@ -17,11 +9,16 @@ use crate::foundation::{id, BOOL, YES, NO};
const UTF8_ENCODING: usize = 4;
/// Wraps an underlying `NSString`.
/// A wrapper for `NSString`.
///
/// We can make a few safety guarantees in this module as the UTF8 code on the Foundation
/// side is fairly battle tested.
#[derive(Debug)]
pub struct NSString(pub Id<Object>);
impl NSString {
/// Creates a new `NSString`. Note that `NSString` lives on the heap, so this allocates
/// accordingly.
pub fn new(s: &str) -> Self {
NSString(unsafe {
let nsstring: *mut Object = msg_send![class!(NSString), alloc];
@ -30,12 +27,15 @@ impl NSString {
})
}
/// In cases where we're vended an `NSString` by the system, this can be used to wrap and
/// retain it.
pub fn wrap(object: id) -> Self {
NSString(unsafe {
Id::from_ptr(object)
})
}
/// Utility method for checking whether an `NSObject` is an `NSString`.
pub fn is(obj: id) -> bool {
let result: BOOL = unsafe { msg_send![obj, isKindOfClass:class!(NSString)] };
@ -46,21 +46,39 @@ impl NSString {
}
}
pub fn into_inner(mut self) -> id {
&mut *self.0
/// Helper method for returning the UTF8 bytes for this `NSString`.
fn bytes(&self) -> *const u8 {
unsafe {
let bytes: *const c_char = msg_send![&*self.0, UTF8String];
bytes as *const u8
}
}
/// Helper method for grabbing the proper byte length for this `NSString` (the UTF8 variant).
fn bytes_len(&self) -> usize {
unsafe {
msg_send![&*self.0, lengthOfBytesUsingEncoding:UTF8_ENCODING]
}
}
/// A utility method for taking an `NSString` and bridging it to a Rust `&str`.
pub fn to_str(self) -> &'static str {
pub fn to_str(&self) -> &str {
let bytes = self.bytes();
let len = self.bytes_len();
unsafe {
let bytes = {
let bytes: *const c_char = msg_send![&*self.0, UTF8String];
bytes as *const u8
};
let len = msg_send![&*self.0, lengthOfBytesUsingEncoding:UTF8_ENCODING];
let bytes = slice::from_raw_parts(bytes, len);
str::from_utf8(bytes).unwrap()
}
}
/// A utility method for taking an `NSString` and getting an owned `String` from it.
pub fn to_string(&self) -> String {
self.to_str().to_string()
}
/// Consumes and returns the underlying `NSString` instance.
pub fn into_inner(mut self) -> id {
&mut *self.0
}
}

2
src/macos/app/delegate.rs
View file

@ -195,7 +195,7 @@ extern fn did_receive_remote_notification<T: AppDelegate>(_this: &Object, _: Sel
/// Fires when the application receives a `application:userDidAcceptCloudKitShareWithMetadata:`
/// message.
#[cfg(feature = "cloudkit")]
extern fn accepted_cloudkit_share<T: AppDelegate>(_this: &Object, _: Sel, _: id, metadata: id) {
extern fn accepted_cloudkit_share<T: AppDelegate>(this: &Object, _: Sel, _: id, metadata: id) {
let share = CKShareMetaData::with_inner(metadata);
app::<T>(this).user_accepted_cloudkit_share(share);
}

5
src/macos/toolbar/class.rs
View file

@ -13,7 +13,6 @@ use crate::utils::load;
/// Retrieves and passes the allowed item identifiers for this toolbar.
extern fn allowed_item_identifiers<T: ToolbarDelegate>(this: &Object, _: Sel, _: id) -> id {
let toolbar = load::<T>(this, TOOLBAR_PTR);
println!("Hitting here?");
let identifiers: NSArray = toolbar.allowed_item_identifiers().iter().map(|identifier| {
NSString::new(identifier).into_inner()
@ -37,9 +36,9 @@ extern fn default_item_identifiers<T: ToolbarDelegate>(this: &Object, _: Sel, _:
/// Objective-C runtime needs.
extern fn item_for_identifier<T: ToolbarDelegate>(this: &Object, _: Sel, _: id, identifier: id, _: id) -> id {
let toolbar = load::<T>(this, TOOLBAR_PTR);
let identifier = NSString::wrap(identifier).to_str();
let identifier = NSString::wrap(identifier);
let mut item = toolbar.item_for(identifier);
let mut item = toolbar.item_for(identifier.to_str());
&mut *item.objc
}

4
src/networking/mod.rs
View file

@ -19,10 +19,10 @@ impl URLRequest {
}
}
pub fn url(&self) -> &'static str {
pub fn url(&self) -> String {
NSString::wrap(unsafe {
let url: id = msg_send![&*self.inner, URL];
msg_send![url, absoluteString]
}).to_str()
}).to_string()
}
}

7
src/user_notifications/mod.rs
View file

@ -26,9 +26,10 @@ impl NotificationCenter {
unsafe {
// @TODO: Revisit.
let block = ConcreteBlock::new(|_: id, error: id| {
let localized_description = NSString::new(msg_send![error, localizedDescription]).to_str();
if localized_description != "" {
println!("{:?}", localized_description);
let localized_description = NSString::wrap(msg_send![error, localizedDescription]);
let e = localized_description.to_str();
if e != "" {
println!("{:?}", e);
}
});

14
src/webview/class.rs
View file

@ -19,8 +19,8 @@ use crate::utils::load;
/// Called when an `alert()` from the underlying `WKWebView` is fired. Will call over to your
/// `WebViewController`, where you should handle the event.
extern fn alert<T: WebViewDelegate>(_: &Object, _: Sel, _: id, s: id, _: id, complete: id) {
let alert = NSString::wrap(s).to_str();
extern fn alert<T: WebViewDelegate>(_: &Object, _: Sel, _: id, _: id, _: id, complete: id) {
//let alert = NSString::wrap(s).to_str();
// @TODO: This is technically (I think?) a private method, and there's some other dance that
// needs to be done here involving taking the pointer/invoke/casting... but this is fine for
@ -47,9 +47,9 @@ extern fn on_message<T: WebViewDelegate>(this: &Object, _: Sel, _: id, script_me
let delegate = load::<T>(this, WEBVIEW_DELEGATE_PTR);
unsafe {
let name = NSString::wrap(msg_send![script_message, name]).to_str();
let body = NSString::wrap(msg_send![script_message, body]).to_str();
delegate.on_message(name, body);
let name = NSString::wrap(msg_send![script_message, name]);
let body = NSString::wrap(msg_send![script_message, body]);
delegate.on_message(name.to_str(), body.to_str());
}
}
@ -107,9 +107,9 @@ extern fn handle_download<T: WebViewDelegate>(this: &Object, _: Sel, download: i
let delegate = load::<T>(this, WEBVIEW_DELEGATE_PTR);
let handler = handler as *const Block<(objc::runtime::BOOL, id), c_void>;
let filename = NSString::wrap(suggested_filename).to_str();
let filename = NSString::wrap(suggested_filename);
delegate.run_save_panel(filename, move |can_overwrite, path| unsafe {
delegate.run_save_panel(filename.to_str(), move |can_overwrite, path| unsafe {
if path.is_none() {
let _: () = msg_send![download, cancel];
}