From adaf203e73a7fc3aec0604db8f0a63bdd03543f4 Mon Sep 17 00:00:00 2001
From: Alex Janka <alex@alexjanka.com>
Date: Sat, 25 Mar 2023 17:23:48 +1100
Subject: [PATCH] better error messages for parsing rom title
---
lib/src/processor/memory/rom.rs | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/src/processor/memory/rom.rs b/lib/src/processor/memory/rom.rs
index 2d436a2..197aac0 100644
--- a/lib/src/processor/memory/rom.rs
+++ b/lib/src/processor/memory/rom.rs
@@ -9,7 +9,7 @@ use std::{
io::{Read, Seek, SeekFrom, Write},
marker::PhantomData,
path::PathBuf,
- str::from_utf8_unchecked,
+ str::from_utf8,
};
use self::mbcs::{
@@ -194,7 +194,9 @@ where
break;
}
}
- let title = unsafe { from_utf8_unchecked(&data[0x134..title_length]).to_string() };
+ let title = from_utf8(&data[0x134..title_length])
+ .expect("Error parsing title")
+ .to_string();
let _gbc_flag = data[0x143];