From db00e1e24d52bc77948e8eaf7d8fabc0649e2cb3 Mon Sep 17 00:00:00 2001 From: Lokathor Date: Sun, 11 Nov 2018 00:30:13 -0700 Subject: [PATCH] Remove trivial commented out code no need to "keep it for later" when it's just an import --- src/lib.rs | 5 ----- src/macros.rs | 6 ++++-- src/video_ram.rs | 4 +--- 3 files changed, 5 insertions(+), 10 deletions(-) diff --git a/src/lib.rs b/src/lib.rs index bf9c498..d04d888 100644 --- a/src/lib.rs +++ b/src/lib.rs @@ -14,17 +14,12 @@ //! **Do not** use this crate in programs that aren't running on the GBA. If you //! do, it's a giant bag of Undefined Behavior. -//pub(crate) use gba_proc_macro::bit_register; -//pub mod macros; // un-comment once we get some - pub mod core_extras; pub(crate) use crate::core_extras::*; pub mod io_registers; -//pub(crate) use crate::io_registers::*; pub mod video_ram; -//pub(crate) use crate::video_ram::*; /// Combines the Red, Blue, and Green provided into a single color value. pub const fn rgb16(red: u16, green: u16, blue: u16) -> u16 { diff --git a/src/macros.rs b/src/macros.rs index a81a6bc..3a38290 100644 --- a/src/macros.rs +++ b/src/macros.rs @@ -1,6 +1,8 @@ //! Module for all macros. //! -//! Macros are the only thing in rust where declaration order matters, so we -//! place all of them here regardless of what they do. +//! Macros are the only thing in Rust where declaration order matters, so we +//! place all of them here regardless of what they do so that the macros module +//! can appear at the "top" of the library and all other modules can see them +//! properly. // no macros yet! diff --git a/src/video_ram.rs b/src/video_ram.rs index 549e707..a41cada 100644 --- a/src/video_ram.rs +++ b/src/video_ram.rs @@ -1,6 +1,6 @@ //! Module for all things relating to the Video RAM. //! -//! Note that that GBA has six different display modes available, and the +//! Note that the GBA has six different display modes available, and the //! _meaning_ of Video RAM depends on which display mode is active. In all //! cases, Video RAM is **96kb** from `0x0600_0000` to `0x0601_7FFF`. //! @@ -13,8 +13,6 @@ //! they won't bother to check that you've set the video mode they're designed //! for. -//use super::*; - /// The physical width in pixels of the GBA screen. pub const SCREEN_WIDTH: isize = 240;