shaders can be either a path or a string

Fixes #79, #78

librashader-capi/src/ctypes.rs

@@ -181,7 +181,6 @@ pub(crate) use config_struct;
 pub(crate) use config_version_set;
 
 #[doc(hidden)]
-#[deny(deprecated)]
 #[deprecated = "Forward declarations for cbindgen, do not use."]
 mod __cbindgen_opaque_forward_declarations {
     macro_rules! typedef_struct {
@@ -189,7 +188,6 @@ mod __cbindgen_opaque_forward_declarations {
             $($(#[$($attrss)*])*
                 #[allow(unused)]
                 #[doc(hidden)]
-                #[deny(deprecated)]
                 #[deprecated]
                 pub struct $name;
             )*

librashader-capi/src/lib.rs

@@ -66,7 +66,6 @@
 #![allow(non_camel_case_types)]
 #![feature(try_blocks)]
 #![deny(unsafe_op_in_unsafe_fn)]
-#![deny(deprecated)]
 
 extern crate alloc;
 

librashader-runtime-d3d11/src/filter_chain.rs

@@ -75,28 +75,34 @@ pub(crate) struct FilterCommon {
     pub(crate) draw_quad: DrawQuad,
 }
 
-type ShaderPassMeta =
+mod compile {
-    ShaderPassArtifact<impl CompileReflectShader<HLSL, SpirvCompilation, SpirvCross> + Send>;
+    use super::*;
-fn compile_passes(
+    pub type ShaderPassMeta =
-    shaders: Vec<ShaderPassConfig>,
+        ShaderPassArtifact<impl CompileReflectShader<HLSL, SpirvCompilation, SpirvCross> + Send>;
-    textures: &[TextureConfig],
-    disable_cache: bool,
-) -> Result<(Vec<ShaderPassMeta>, ShaderSemantics), FilterChainError> {
-    let (passes, semantics) = if !disable_cache {
-        HLSL::compile_preset_passes::<
-            CachedCompilation<SpirvCompilation>,
-            SpirvCross,
-            FilterChainError,
-        >(shaders, &textures)?
-    } else {
-        HLSL::compile_preset_passes::<SpirvCompilation, SpirvCross, FilterChainError>(
-            shaders, &textures,
-        )?
-    };
 
-    Ok((passes, semantics))
+    pub fn compile_passes(
+        shaders: Vec<ShaderPassConfig>,
+        textures: &[TextureConfig],
+        disable_cache: bool,
+    ) -> Result<(Vec<ShaderPassMeta>, ShaderSemantics), FilterChainError> {
+        let (passes, semantics) = if !disable_cache {
+            HLSL::compile_preset_passes::<
+                CachedCompilation<SpirvCompilation>,
+                SpirvCross,
+                FilterChainError,
+            >(shaders, &textures)?
+        } else {
+            HLSL::compile_preset_passes::<SpirvCompilation, SpirvCross, FilterChainError>(
+                shaders, &textures,
+            )?
+        };
+
+        Ok((passes, semantics))
+    }
 }
 
+use compile::{compile_passes, ShaderPassMeta};
+
 impl FilterChainD3D11 {
     /// Load the shader preset at the given path into a filter chain.
     pub unsafe fn load_from_path(

librashader-runtime-d3d12/src/filter_chain.rs

@@ -146,49 +146,57 @@ impl Drop for FrameResiduals {
     }
 }
 
-type DxilShaderPassMeta =
+mod compile {
-    ShaderPassArtifact<impl CompileReflectShader<DXIL, SpirvCompilation, SpirvCross> + Send>;
+    use super::*;
-fn compile_passes_dxil(
+    pub type DxilShaderPassMeta =
-    shaders: Vec<ShaderPassConfig>,
+        ShaderPassArtifact<impl CompileReflectShader<DXIL, SpirvCompilation, SpirvCross> + Send>;
-    textures: &[TextureConfig],
-    disable_cache: bool,
-) -> Result<(Vec<DxilShaderPassMeta>, ShaderSemantics), FilterChainError> {
-    let (passes, semantics) = if !disable_cache {
-        DXIL::compile_preset_passes::<
-            CachedCompilation<SpirvCompilation>,
-            SpirvCross,
-            FilterChainError,
-        >(shaders, &textures)?
-    } else {
-        DXIL::compile_preset_passes::<SpirvCompilation, SpirvCross, FilterChainError>(
-            shaders, &textures,
-        )?
-    };
 
-    Ok((passes, semantics))
+    pub fn compile_passes_dxil(
-}
+        shaders: Vec<ShaderPassConfig>,
-type HlslShaderPassMeta =
+        textures: &[TextureConfig],
-    ShaderPassArtifact<impl CompileReflectShader<HLSL, SpirvCompilation, SpirvCross> + Send>;
+        disable_cache: bool,
-fn compile_passes_hlsl(
+    ) -> Result<(Vec<DxilShaderPassMeta>, ShaderSemantics), FilterChainError> {
-    shaders: Vec<ShaderPassConfig>,
+        let (passes, semantics) = if !disable_cache {
-    textures: &[TextureConfig],
+            DXIL::compile_preset_passes::<
-    disable_cache: bool,
+                CachedCompilation<SpirvCompilation>,
-) -> Result<(Vec<HlslShaderPassMeta>, ShaderSemantics), FilterChainError> {
+                SpirvCross,
-    let (passes, semantics) = if !disable_cache {
+                FilterChainError,
-        HLSL::compile_preset_passes::<
+            >(shaders, &textures)?
-            CachedCompilation<SpirvCompilation>,
+        } else {
-            SpirvCross,
+            DXIL::compile_preset_passes::<SpirvCompilation, SpirvCross, FilterChainError>(
-            FilterChainError,
+                shaders, &textures,
-        >(shaders, &textures)?
+            )?
-    } else {
+        };
-        HLSL::compile_preset_passes::<SpirvCompilation, SpirvCross, FilterChainError>(
-            shaders, &textures,
-        )?
-    };
 
-    Ok((passes, semantics))
+        Ok((passes, semantics))
+    }
+
+    pub type HlslShaderPassMeta =
+        ShaderPassArtifact<impl CompileReflectShader<HLSL, SpirvCompilation, SpirvCross> + Send>;
+
+    pub fn compile_passes_hlsl(
+        shaders: Vec<ShaderPassConfig>,
+        textures: &[TextureConfig],
+        disable_cache: bool,
+    ) -> Result<(Vec<HlslShaderPassMeta>, ShaderSemantics), FilterChainError> {
+        let (passes, semantics) = if !disable_cache {
+            HLSL::compile_preset_passes::<
+                CachedCompilation<SpirvCompilation>,
+                SpirvCross,
+                FilterChainError,
+            >(shaders, &textures)?
+        } else {
+            HLSL::compile_preset_passes::<SpirvCompilation, SpirvCross, FilterChainError>(
+                shaders, &textures,
+            )?
+        };
+
+        Ok((passes, semantics))
+    }
 }
 
+use compile::{compile_passes_dxil, compile_passes_hlsl, DxilShaderPassMeta, HlslShaderPassMeta};
+
 impl FilterChainD3D12 {
     /// Load the shader preset at the given path into a filter chain.
     pub unsafe fn load_from_path(

librashader-runtime-d3d9/src/filter_chain.rs

@@ -63,29 +63,34 @@ pub struct FilterChainD3D9 {
     default_options: FrameOptionsD3D9,
 }
 
-type ShaderPassMeta =
+mod compile {
-    ShaderPassArtifact<impl CompileReflectShader<HLSL, SpirvCompilation, SpirvCross> + Send>;
+    use super::*;
+    pub type ShaderPassMeta =
+        ShaderPassArtifact<impl CompileReflectShader<HLSL, SpirvCompilation, SpirvCross> + Send>;
 
-fn compile_passes(
+    pub fn compile_passes(
-    shaders: Vec<ShaderPassConfig>,
+        shaders: Vec<ShaderPassConfig>,
-    textures: &[TextureConfig],
+        textures: &[TextureConfig],
-    disable_cache: bool,
+        disable_cache: bool,
-) -> Result<(Vec<ShaderPassMeta>, ShaderSemantics), FilterChainError> {
+    ) -> Result<(Vec<ShaderPassMeta>, ShaderSemantics), FilterChainError> {
-    let (passes, semantics) = if !disable_cache {
+        let (passes, semantics) = if !disable_cache {
-        HLSL::compile_preset_passes::<
+            HLSL::compile_preset_passes::<
-            CachedCompilation<SpirvCompilation>,
+                CachedCompilation<SpirvCompilation>,
-            SpirvCross,
+                SpirvCross,
-            FilterChainError,
+                FilterChainError,
-        >(shaders, &textures)?
+            >(shaders, &textures)?
-    } else {
+        } else {
-        HLSL::compile_preset_passes::<SpirvCompilation, SpirvCross, FilterChainError>(
+            HLSL::compile_preset_passes::<SpirvCompilation, SpirvCross, FilterChainError>(
-            shaders, &textures,
+                shaders, &textures,
-        )?
+            )?
-    };
+        };
 
-    Ok((passes, semantics))
+        Ok((passes, semantics))
+    }
 }
 
+use compile::{compile_passes, ShaderPassMeta};
+
 impl FilterChainD3D9 {
     fn init_passes(
         device: &IDirect3DDevice9,

librashader-runtime-gl/src/filter_chain/filter_impl.rs

@@ -92,28 +92,34 @@ impl<T: GLInterface> FilterChainImpl<T> {
     }
 }
 
-type ShaderPassMeta =
+mod compile {
-    ShaderPassArtifact<impl CompileReflectShader<GLSL, SpirvCompilation, SpirvCross>>;
+    use super::*;
-fn compile_passes(
+    pub type ShaderPassMeta =
-    shaders: Vec<ShaderPassConfig>,
+        ShaderPassArtifact<impl CompileReflectShader<GLSL, SpirvCompilation, SpirvCross>>;
-    textures: &[TextureConfig],
-    disable_cache: bool,
-) -> Result<(Vec<ShaderPassMeta>, ShaderSemantics), FilterChainError> {
-    let (passes, semantics) = if !disable_cache {
-        GLSL::compile_preset_passes::<
-            CachedCompilation<SpirvCompilation>,
-            SpirvCross,
-            FilterChainError,
-        >(shaders, &textures)?
-    } else {
-        GLSL::compile_preset_passes::<SpirvCompilation, SpirvCross, FilterChainError>(
-            shaders, &textures,
-        )?
-    };
 
-    Ok((passes, semantics))
+    pub fn compile_passes(
+        shaders: Vec<ShaderPassConfig>,
+        textures: &[TextureConfig],
+        disable_cache: bool,
+    ) -> Result<(Vec<ShaderPassMeta>, ShaderSemantics), FilterChainError> {
+        let (passes, semantics) = if !disable_cache {
+            GLSL::compile_preset_passes::<
+                CachedCompilation<SpirvCompilation>,
+                SpirvCross,
+                FilterChainError,
+            >(shaders, &textures)?
+        } else {
+            GLSL::compile_preset_passes::<SpirvCompilation, SpirvCross, FilterChainError>(
+                shaders, &textures,
+            )?
+        };
+
+        Ok((passes, semantics))
+    }
 }
 
+use compile::{compile_passes, ShaderPassMeta};
+
 impl<T: GLInterface> FilterChainImpl<T> {
     /// Load a filter chain from a pre-parsed `ShaderPreset`.
     pub(crate) unsafe fn load_from_preset(

librashader-runtime-mtl/src/filter_chain.rs

@@ -40,19 +40,25 @@ use std::collections::VecDeque;
 use std::fmt::{Debug, Formatter};
 use std::path::Path;
 
-type ShaderPassMeta =
+mod compile {
-    ShaderPassArtifact<impl CompileReflectShader<MSL, SpirvCompilation, SpirvCross> + Send>;
+    use super::*;
-fn compile_passes(
+    pub type ShaderPassMeta =
-    shaders: Vec<ShaderPassConfig>,
+        ShaderPassArtifact<impl CompileReflectShader<MSL, SpirvCompilation, SpirvCross> + Send>;
-    textures: &[TextureConfig],
+
-) -> Result<(Vec<ShaderPassMeta>, ShaderSemantics), FilterChainError> {
+    pub fn compile_passes(
-    let (passes, semantics) =
+        shaders: Vec<ShaderPassConfig>,
-        MSL::compile_preset_passes::<SpirvCompilation, SpirvCross, FilterChainError>(
+        textures: &[TextureConfig],
-            shaders, &textures,
+    ) -> Result<(Vec<ShaderPassMeta>, ShaderSemantics), FilterChainError> {
-        )?;
+        let (passes, semantics) =
-    Ok((passes, semantics))
+            MSL::compile_preset_passes::<SpirvCompilation, SpirvCross, FilterChainError>(
+                shaders, &textures,
+            )?;
+        Ok((passes, semantics))
+    }
 }
 
+use compile::{compile_passes, ShaderPassMeta};
+
 /// A Metal filter chain.
 pub struct FilterChainMetal {
     pub(crate) common: FilterCommon,

librashader-runtime-vk/src/filter_chain.rs

@@ -209,28 +209,34 @@ impl Drop for FrameResiduals {
     }
 }
 
-type ShaderPassMeta =
+mod compile {
-    ShaderPassArtifact<impl CompileReflectShader<SPIRV, SpirvCompilation, SpirvCross> + Send>;
+    use super::*;
-fn compile_passes(
+    pub type ShaderPassMeta =
-    shaders: Vec<ShaderPassConfig>,
+        ShaderPassArtifact<impl CompileReflectShader<SPIRV, SpirvCompilation, SpirvCross> + Send>;
-    textures: &[TextureConfig],
-    disable_cache: bool,
-) -> Result<(Vec<ShaderPassMeta>, ShaderSemantics), FilterChainError> {
-    let (passes, semantics) = if !disable_cache {
-        SPIRV::compile_preset_passes::<
-            CachedCompilation<SpirvCompilation>,
-            SpirvCross,
-            FilterChainError,
-        >(shaders, &textures)?
-    } else {
-        SPIRV::compile_preset_passes::<SpirvCompilation, SpirvCross, FilterChainError>(
-            shaders, &textures,
-        )?
-    };
 
-    Ok((passes, semantics))
+    pub fn compile_passes(
+        shaders: Vec<ShaderPassConfig>,
+        textures: &[TextureConfig],
+        disable_cache: bool,
+    ) -> Result<(Vec<ShaderPassMeta>, ShaderSemantics), FilterChainError> {
+        let (passes, semantics) = if !disable_cache {
+            SPIRV::compile_preset_passes::<
+                CachedCompilation<SpirvCompilation>,
+                SpirvCross,
+                FilterChainError,
+            >(shaders, &textures)?
+        } else {
+            SPIRV::compile_preset_passes::<SpirvCompilation, SpirvCross, FilterChainError>(
+                shaders, &textures,
+            )?
+        };
+
+        Ok((passes, semantics))
+    }
 }
 
+use compile::{compile_passes, ShaderPassMeta};
+
 impl FilterChainVulkan {
     /// Load the shader preset at the given path into a filter chain.
     pub unsafe fn load_from_path<V, E>(

librashader-runtime-wgpu/Cargo.toml

@@ -21,7 +21,7 @@ librashader-reflect = { path = "../librashader-reflect", version = "0.2.7", feat
 librashader-runtime = { path = "../librashader-runtime" , version = "0.2.7" }
 
 wgpu = { version = "0.20.0", default-features = false, features = ["wgsl"] }
-image = "0.24.7"
+image = "0.25.1"
 thiserror = "1.0.50"
 bytemuck = { version = "1.14.0", features = ["derive"] }
 array-concat = "0.5.2"

librashader-runtime-wgpu/src/filter_chain.rs

@@ -38,19 +38,25 @@ use crate::options::{FilterChainOptionsWgpu, FrameOptionsWgpu};
 use crate::samplers::SamplerSet;
 use crate::texture::{InputImage, OwnedImage};
 
-type ShaderPassMeta =
+mod compile {
-    ShaderPassArtifact<impl CompileReflectShader<WGSL, SpirvCompilation, Naga> + Send>;
+    use super::*;
-fn compile_passes(
+    pub type ShaderPassMeta =
-    shaders: Vec<ShaderPassConfig>,
+        ShaderPassArtifact<impl CompileReflectShader<WGSL, SpirvCompilation, Naga> + Send>;
-    textures: &[TextureConfig],
+
-) -> Result<(Vec<ShaderPassMeta>, ShaderSemantics), FilterChainError> {
+    pub fn compile_passes(
-    let (passes, semantics) =
+        shaders: Vec<ShaderPassConfig>,
-        WGSL::compile_preset_passes::<SpirvCompilation, Naga, FilterChainError>(
+        textures: &[TextureConfig],
-            shaders, &textures,
+    ) -> Result<(Vec<ShaderPassMeta>, ShaderSemantics), FilterChainError> {
-        )?;
+        let (passes, semantics) =
-    Ok((passes, semantics))
+            WGSL::compile_preset_passes::<SpirvCompilation, Naga, FilterChainError>(
+                shaders, &textures,
+            )?;
+        Ok((passes, semantics))
+    }
 }
 
+use compile::{compile_passes, ShaderPassMeta};
+
 /// A wgpu filter chain.
 pub struct FilterChainWgpu {
     pub(crate) common: FilterCommon,

librashader-runtime/Cargo.toml

@@ -23,7 +23,7 @@ array-concat = "0.5.2"
 tinymap = "0.4.0"
 
 [dependencies.image]
-version = "0.24.5"
+version = "0.25.1"
 features = [
     "gif", "jpeg", "png",
     "tga", "pnm", "tiff",

librashader-runtime/src/scaling.rs

@@ -5,24 +5,27 @@ use librashader_presets::{Scale2D, ScaleFactor, ScaleType, Scaling};
 use num_traits::AsPrimitive;
 use std::ops::Mul;
 
+pub const MAX_TEXEL_SIZE: f32 = 16384f32;
+
 /// Trait for size scaling relative to the viewport.
 pub trait ViewportSize<T>
 where
-    T: Mul<ScaleFactor, Output = f32> + Copy + 'static,
+    T: Mul<ScaleFactor, Output = f32> + Copy + Ord + 'static,
     f32: AsPrimitive<T>,
 {
     /// Produce a `Size<T>` scaled with the input scaling options.
+    /// The size will at minimum be 1x1, and at a maximum 16384x16384.
     fn scale_viewport(self, scaling: Scale2D, viewport: Size<T>, original: Size<T>) -> Size<T>;
 }
 
 impl<T> ViewportSize<T> for Size<T>
 where
-    T: Mul<ScaleFactor, Output = f32> + Copy + 'static,
+    T: Mul<ScaleFactor, Output = f32> + Copy + Ord + 'static,
     f32: AsPrimitive<T>,
 {
     fn scale_viewport(self, scaling: Scale2D, viewport: Size<T>, original: Size<T>) -> Size<T>
     where
-        T: Mul<ScaleFactor, Output = f32> + Copy + 'static,
+        T: Mul<ScaleFactor, Output = f32> + Copy + Ord + 'static,
         f32: AsPrimitive<T>,
     {
         scaling::scale(scaling, self, viewport, original)
@@ -35,6 +38,7 @@ pub trait MipmapSize<T> {
     fn calculate_miplevels(self) -> T;
 
     /// Scale the size according to the given mipmap level.
+    /// The size will at minimum be 1x1, and at a maximum 16384x16384.
     fn scale_mipmap(self, miplevel: T) -> Size<T>;
 }
 
@@ -59,7 +63,7 @@ impl MipmapSize<u32> for Size<u32> {
 
 fn scale<T>(scaling: Scale2D, source: Size<T>, viewport: Size<T>, original: Size<T>) -> Size<T>
 where
-    T: Mul<ScaleFactor, Output = f32> + Copy + 'static,
+    T: Mul<ScaleFactor, Output = f32> + Copy + Ord + 'static,
     f32: AsPrimitive<T>,
 {
     let width = match scaling.x {
@@ -101,8 +105,14 @@ where
     };
 
     Size {
-        width: width.round().as_(),
+        width: std::cmp::min(
-        height: height.round().as_(),
+            std::cmp::max(width.round().as_(), 1f32.as_()),
+            MAX_TEXEL_SIZE.as_(),
+        ),
+        height: std::cmp::min(
+            std::cmp::max(height.round().as_(), 1f32.as_()),
+            MAX_TEXEL_SIZE.as_(),
+        ),
     }
 }