alex/nih-plug
1
0
Fork 0
Code Activity

Fix unused/dead code warnings with VST3 disabled

Browse source
This commit is contained in:
Robbert van der Helm 2023-02-19 13:19:02 +01:00
parent 5ddcc3bc7d
commit 090b4b529f
3 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/event_loop.rs
View file

@ -13,13 +13,13 @@ mod windows;
pub(crate) use self::background_thread::BackgroundThread; pub(crate) use self::background_thread::BackgroundThread;
#[allow(unused_imports)] #[cfg_attr(not(feature = "vst3"), allow(unused_imports))]
#[cfg(all(target_family = "unix", not(target_os = "macos")))] #[cfg(all(target_family = "unix", not(target_os = "macos")))]
pub(crate) use self::linux::LinuxEventLoop as OsEventLoop; pub(crate) use self::linux::LinuxEventLoop as OsEventLoop;
#[allow(unused_imports)] #[cfg_attr(not(feature = "vst3"), allow(unused_imports))]
#[cfg(target_os = "macos")] #[cfg(target_os = "macos")]
pub(crate) use self::macos::MacOSEventLoop as OsEventLoop; pub(crate) use self::macos::MacOSEventLoop as OsEventLoop;
#[allow(unused_imports)] #[cfg_attr(not(feature = "vst3"), allow(unused_imports))]
#[cfg(target_os = "windows")] #[cfg(target_os = "windows")]
pub(crate) use self::windows::WindowsEventLoop as OsEventLoop; pub(crate) use self::windows::WindowsEventLoop as OsEventLoop;

1
src/midi.rs
View file

@ -598,6 +598,7 @@ impl<S: SysExMessage> NoteEvent<S> {
/// Subtract a sample offset from this event's timing, needed to compensate for the block /// Subtract a sample offset from this event's timing, needed to compensate for the block
/// splitting in the VST3 wrapper implementation because all events have to be read upfront. /// splitting in the VST3 wrapper implementation because all events have to be read upfront.
#[cfg_attr(not(feature = "vst3"), allow(dead_code))]
pub(crate) fn subtract_timing(&mut self, samples: u32) { pub(crate) fn subtract_timing(&mut self, samples: u32) {
match self { match self {
NoteEvent::NoteOn { timing, .. } => *timing -= samples, NoteEvent::NoteOn { timing, .. } => *timing -= samples,

4
src/plugin.rs
View file

@ -263,12 +263,12 @@ pub trait Vst3Plugin: Plugin {
const PLATFORM_VST3_CLASS_ID: [u8; 16] = swap_vst3_uid_byte_order(Self::VST3_CLASS_ID); const PLATFORM_VST3_CLASS_ID: [u8; 16] = swap_vst3_uid_byte_order(Self::VST3_CLASS_ID);
} }
#[cfg(not(target_os = "windows"))] #[cfg(all(feature = "vst3", not(target_os = "windows")))]
const fn swap_vst3_uid_byte_order(uid: [u8; 16]) -> [u8; 16] { const fn swap_vst3_uid_byte_order(uid: [u8; 16]) -> [u8; 16] {
uid uid
} }
#[cfg(target_os = "windows")] #[cfg(all(feature = "vst3", target_os = "windows"))]
const fn swap_vst3_uid_byte_order(mut uid: [u8; 16]) -> [u8; 16] { const fn swap_vst3_uid_byte_order(mut uid: [u8; 16]) -> [u8; 16] {
// No mutable references in const functions, so we can't use `uid.swap()` // No mutable references in const functions, so we can't use `uid.swap()`
let original_uid = uid; let original_uid = uid;