From 0d5247ee2f2e4b9e773daca6ad6b784bd2d102f8 Mon Sep 17 00:00:00 2001
From: Robbert van der Helm <mail@robbertvanderhelm.nl>
Date: Sat, 18 Mar 2023 15:16:52 +0100
Subject: [PATCH] Fix ParamButton hover state and styling

---
 CHANGELOG.md                                          | 9 +++++++++
 nih_plug_vizia/assets/widgets.css                     | 6 +++---
 nih_plug_vizia/src/widgets/param_button.rs            | 3 ++-
 plugins/diopser/src/editor/button.rs                  | 2 +-
 plugins/spectral_compressor/src/editor/mode_button.rs | 2 +-
 5 files changed, 16 insertions(+), 6 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 3e920660..caa81c63 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -10,6 +10,15 @@ Since there is no stable release yet, the changes are organized per day in
 reverse chronological order. The main purpose of this document in its current
 state is to list breaking changes.
 
+## [HEAD]
+
+This needs to be moved to a specific date when the below changes are merged.
+
+### Changed
+
+- `nih_plug_vizia`: `ParamButton`'s active color was made much lighter to make
+  the text more readable, and the hover state has been fixed.
+
 ## [2023-03-18]
 
 ### Added
diff --git a/nih_plug_vizia/assets/widgets.css b/nih_plug_vizia/assets/widgets.css
index 692c9821..d36f56b0 100644
--- a/nih_plug_vizia/assets/widgets.css
+++ b/nih_plug_vizia/assets/widgets.css
@@ -35,15 +35,15 @@ param-button {
   child-right: 7px;
   child-bottom: 1s;
   child-left: 7px;
-  background-color: #80808000;
+  background-color: #d0d0d000;
   transition: background-color 0.1 0;
 }
 param-button:hover {
-  background-color: #80808020;
+  background-color: #d0d0d080;
   transition: background-color 0.1 0;
 }
 param-button:checked {
-  background-color: #808080;
+  background-color: #d0d0d0;
   transition: background-color 0.1 0;
 }
 
diff --git a/nih_plug_vizia/src/widgets/param_button.rs b/nih_plug_vizia/src/widgets/param_button.rs
index 333ae340..9654a190 100644
--- a/nih_plug_vizia/src/widgets/param_button.rs
+++ b/nih_plug_vizia/src/widgets/param_button.rs
@@ -53,7 +53,8 @@ impl ParamButton {
                     match label_override.get(cx) {
                         Some(label_override) => Label::new(cx, &label_override),
                         None => Label::new(cx, param_data.param().name()),
-                    };
+                    }
+                    .hoverable(false);
                 })
             }),
         )
diff --git a/plugins/diopser/src/editor/button.rs b/plugins/diopser/src/editor/button.rs
index 1343cd2f..50e7ce70 100644
--- a/plugins/diopser/src/editor/button.rs
+++ b/plugins/diopser/src/editor/button.rs
@@ -40,7 +40,7 @@ impl<L: Lens<Target = SafeModeClamper>> SafeModeButton<L> {
             scrolled_lines: 0.0,
         }
         .build(cx, move |cx| {
-            Label::new(cx, label);
+            Label::new(cx, label).hoverable(false);
         })
         .checked(lens.map(|v| v.status()))
         // We'll pretend this is a param-button, so this class is used for assigning a unique color
diff --git a/plugins/spectral_compressor/src/editor/mode_button.rs b/plugins/spectral_compressor/src/editor/mode_button.rs
index 2e14d9aa..da7fa923 100644
--- a/plugins/spectral_compressor/src/editor/mode_button.rs
+++ b/plugins/spectral_compressor/src/editor/mode_button.rs
@@ -36,7 +36,7 @@ impl EditorModeButton {
     {
         Self { mode: lens.get(cx) }
             .build(cx, move |cx| {
-                Label::new(cx, label);
+                Label::new(cx, label).hoverable(false);
             })
             .checked(lens.map(|v| v.load() == EditorMode::VisualizerVisible))
             // We'll pretend this is a param-button, so this class is used for assigning a unique