diff --git a/src/wrapper/clap/wrapper.rs b/src/wrapper/clap/wrapper.rs index c45c4151..98a09fb9 100644 --- a/src/wrapper/clap/wrapper.rs +++ b/src/wrapper/clap/wrapper.rs @@ -1438,7 +1438,6 @@ impl<P: ClapPlugin> Wrapper<P> { // Stepped parameters are unnormalized float parameters since there's no separate step // range option // TODO: This should probably be encapsulated in some way so we don't forget about this in one place - // TODO: Like with VST3, this won't actually do the correct thing with skewed stepped parameters param_info.max_value = step_count.unwrap_or(1) as f64; param_info.default_value = *default_value as f64 * step_count.unwrap_or(1) as f64; } @@ -1462,7 +1461,6 @@ impl<P: ClapPlugin> Wrapper<P> { }; true } else if let Some(param_ptr) = wrapper.param_by_hash.get(¶m_id) { - // TODO: As explained above, this may do strange things with skewed discrete parameters *value = param_ptr.normalized_value() as f64 * param_ptr.step_count().unwrap_or(1) as f64; true diff --git a/src/wrapper/vst3/wrapper.rs b/src/wrapper/vst3/wrapper.rs index cb761217..41f3b80e 100644 --- a/src/wrapper/vst3/wrapper.rs +++ b/src/wrapper/vst3/wrapper.rs @@ -337,8 +337,6 @@ impl<P: Vst3Plugin> IEditController for Wrapper<P> { u16strlcpy(&mut info.title, param_ptr.name()); u16strlcpy(&mut info.short_title, param_ptr.name()); u16strlcpy(&mut info.units, param_ptr.unit()); - // TODO: The host assumes these steps are distributed linearly, so this may cause weird - // behavior with skewed integers info.step_count = param_ptr.step_count().unwrap_or(0) as i32; info.default_normalized_value = *default_value as f64; info.unit_id = vst3_sys::vst::kRootUnitId;