From 14cd737e8fdce4e8895d69d27a57ac32d382e33c Mon Sep 17 00:00:00 2001 From: Robbert van der Helm Date: Tue, 21 Mar 2023 23:51:10 +0100 Subject: [PATCH] Scrap the relative gain reduction idea This looks super confusing. --- plugins/spectral_compressor/CHANGELOG.md | 3 +-- plugins/spectral_compressor/src/editor/analyzer.rs | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/plugins/spectral_compressor/CHANGELOG.md b/plugins/spectral_compressor/CHANGELOG.md index 07152269..500bb1c1 100644 --- a/plugins/spectral_compressor/CHANGELOG.md +++ b/plugins/spectral_compressor/CHANGELOG.md @@ -12,8 +12,7 @@ Versioning](https://semver.org/spec/v2.0.0.html). - Added a basic analyzer that visualizes the target curve, the spectral envelope followers and gain reduction. The current version will be expanded a bit in - the future to show this information relative to the threshold target curve, - with some tooltips for more information. + the future with some tooltips and labels to show more information. ### Changed diff --git a/plugins/spectral_compressor/src/editor/analyzer.rs b/plugins/spectral_compressor/src/editor/analyzer.rs index 26f53725..326587b3 100644 --- a/plugins/spectral_compressor/src/editor/analyzer.rs +++ b/plugins/spectral_compressor/src/editor/analyzer.rs @@ -351,7 +351,6 @@ fn draw_gain_reduction( // the way to the bottom of the spectrum analyzer. 40 dB of additional gain causes // the bar to be drawn from the center all the way to the top of the graph. // NOTE: Y-coordinates go from top to bottom, hence the minus - // TODO: The y-position should be relative to the target curve let t_y = ((-gain_difference_db + 40.0) / 80.0).clamp(0.0, 1.0); path.move_to(bounds.x + (bounds.w * t_start), bounds.y + (bounds.h * 0.5));