alex/nih-plug
1
0
Fork 0
Code Activity

Don't report supporting MIDI and expression events

Browse source 
Since currently these would just get thrown out anyways.
This commit is contained in:
Robbert van der Helm 2022-03-15 22:18:23 +01:00
parent 69e4bc9156
commit 1e9fdeddfb
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/wrapper/clap/wrapper.rs
View file

@ -823,6 +823,8 @@ impl<P: ClapPlugin> Wrapper<P> {
} }
(CLAP_CORE_EVENT_SPACE_ID, CLAP_EVENT_NOTE_EXPRESSION) => { (CLAP_CORE_EVENT_SPACE_ID, CLAP_EVENT_NOTE_EXPRESSION) => {
if P::ACCEPTS_MIDI { if P::ACCEPTS_MIDI {
// We currently don't report supporting this at all in the event filter, add that once
// we support MIDI CCs
// TODO: Implement pressure and other expressions along with MIDI CCs // TODO: Implement pressure and other expressions along with MIDI CCs
} }
@ -830,6 +832,8 @@ impl<P: ClapPlugin> Wrapper<P> {
} }
(CLAP_CORE_EVENT_SPACE_ID, CLAP_EVENT_MIDI) => { (CLAP_CORE_EVENT_SPACE_ID, CLAP_EVENT_MIDI) => {
if P::ACCEPTS_MIDI { if P::ACCEPTS_MIDI {
// We currently don't report supporting this at all in the event filter, add that once
// we support MIDI CCs
// TODO: Implement raw MIDI handling once we add CCs // TODO: Implement raw MIDI handling once we add CCs
} }
@ -1402,8 +1406,9 @@ impl<P: ClapPlugin> Wrapper<P> {
(CLAP_CORE_EVENT_SPACE_ID, CLAP_EVENT_PARAM_VALUE) => true, (CLAP_CORE_EVENT_SPACE_ID, CLAP_EVENT_PARAM_VALUE) => true,
(CLAP_CORE_EVENT_SPACE_ID, CLAP_EVENT_NOTE_ON) (CLAP_CORE_EVENT_SPACE_ID, CLAP_EVENT_NOTE_ON)
| (CLAP_CORE_EVENT_SPACE_ID, CLAP_EVENT_NOTE_OFF) | (CLAP_CORE_EVENT_SPACE_ID, CLAP_EVENT_NOTE_OFF)
| (CLAP_CORE_EVENT_SPACE_ID, CLAP_EVENT_NOTE_EXPRESSION) // TODO: Implement midi CC handling
| (CLAP_CORE_EVENT_SPACE_ID, CLAP_EVENT_MIDI) // | (CLAP_CORE_EVENT_SPACE_ID, CLAP_EVENT_NOTE_EXPRESSION)
// | (CLAP_CORE_EVENT_SPACE_ID, CLAP_EVENT_MIDI)
if P::ACCEPTS_MIDI => if P::ACCEPTS_MIDI =>
{ {
true true