From 1f8db9d9c2bccbc8664d34f36ab3e1ae22ef98aa Mon Sep 17 00:00:00 2001
From: Robbert van der Helm <mail@robbertvanderhelm.nl>
Date: Mon, 11 Apr 2022 19:47:46 +0200
Subject: [PATCH] Mention NoteEvents being zero indexed
---
src/midi.rs | 3 ++-
src/plugin.rs | 3 +--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/midi.rs b/src/midi.rs
index 83343ce0..4e7d37ec 100644
--- a/src/midi.rs
+++ b/src/midi.rs
@@ -20,7 +20,8 @@ pub enum MidiConfig {
/// [`Plugin::MIDI_INPUT`][crate::prelude::Plugin::MIDI_INPUT]. Also check out the
/// [`util`][crate::util] module for convenient conversion functions.
///
-/// All of the timings are sample offsets withing the current buffer.
+/// All of the timings are sample offsets withing the current buffer. All sample, channel and note
+/// numbers are zero-indexed.
#[derive(Debug, Clone, Copy, PartialEq)]
#[non_exhaustive]
pub enum NoteEvent {
diff --git a/src/plugin.rs b/src/plugin.rs
index 0777681b..1778b2a2 100644
--- a/src/plugin.rs
+++ b/src/plugin.rs
@@ -21,8 +21,7 @@ use crate::param::internals::Params;
/// - Sidechain inputs
/// - Multiple output busses
/// - Special handling for offline processing
-/// - Outputting MIDI events from the process function (you can output parmaeter changes from an
-/// editor GUI)
+/// - MIDI SysEx and MIDI2 for CLAP, note expressions and MIDI1 are already supported
#[allow(unused_variables)]
pub trait Plugin: Default + Send + Sync + 'static {
const NAME: &'static str;