alex/nih-plug
1
0
Fork 0
Code Activity

Fix note formatting for 0 Hz

Browse source 
This would result in an underflow, failing the test case.
This commit is contained in:
Robbert van der Helm 2023-01-10 02:28:39 +01:00
parent a9d0e40447
commit 2aa937e370
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/formatters.rs
View file

@ -143,6 +143,12 @@ pub fn v2s_f32_hz_then_khz_with_note_name(
include_cents: bool, include_cents: bool,
) -> Arc<dyn Fn(f32) -> String + Send + Sync> { ) -> Arc<dyn Fn(f32) -> String + Send + Sync> {
Arc::new(move |value| { Arc::new(move |value| {
// With 0.0 this would result in a subtraction below i32's minimum value, and it would look
// ridiculous anyways so we'll just not even bother for tiny values
if value.abs() < 1.0 {
return format!("{value:.digits$} Hz");
}
// This is the inverse of the formula in `f32_midi_note_to_freq` // This is the inverse of the formula in `f32_midi_note_to_freq`
let fractional_note = util::freq_to_midi_note(value); let fractional_note = util::freq_to_midi_note(value);
let note = fractional_note.round(); let note = fractional_note.round();