alex/nih-plug
1
0
Fork 0
Code Activity

Avoid destructuring assignment

Browse source 
Somehow the nightly compiler just lets you do this without needing to
opt in to the unstable feature.
This commit is contained in:
Robbert van der Helm 2022-02-05 16:46:29 +01:00
parent 7c74d1f41d
commit 3e2dc92b22
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/wrapper/util.rs
View file

@ -26,14 +26,16 @@ static A: assert_no_alloc::AllocDisabler = assert_no_alloc::AllocDisabler;
/// A Rabin fingerprint based string hash for parameter ID strings. /// A Rabin fingerprint based string hash for parameter ID strings.
pub fn hash_param_id(id: &str) -> u32 { pub fn hash_param_id(id: &str) -> u32 {
let mut overflow;
let mut overflow2;
let mut has_overflown = false; let mut has_overflown = false;
let mut hash: u32 = 0; let mut hash: u32 = 0;
for char in id.bytes() { for char in id.bytes() {
(hash, overflow) = hash.overflowing_mul(31); // No destructuring assignments on stable Rust yet, somehow that just works on nightly
(hash, overflow2) = hash.overflowing_add(char as u32); // without needing to add a feature attribute
has_overflown |= overflow || overflow2; let (hash2, overflow2) = hash.overflowing_mul(31);
let (hash3, overflow3) = hash2.overflowing_add(char as u32);
hash = hash3;
has_overflown |= overflow2 || overflow3;
} }
if has_overflown { if has_overflown {