From 3ede5ed7514e65cdf1448983b1f012b611abefa3 Mon Sep 17 00:00:00 2001 From: Robbert van der Helm Date: Sun, 6 Feb 2022 15:32:54 +0100 Subject: [PATCH] Move the TODO on GUI opening xruns --- nih_plug_egui/src/lib.rs | 1 - src/wrapper/vst3.rs | 4 ++++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/nih_plug_egui/src/lib.rs b/nih_plug_egui/src/lib.rs index 70f0dec3..766c0546 100644 --- a/nih_plug_egui/src/lib.rs +++ b/nih_plug_egui/src/lib.rs @@ -35,7 +35,6 @@ pub use egui; /// your plugin' [nih_plug::Plugin::editor_size()] implementation. // // TODO: DPI scaling, this needs to be implemented on the framework level -// TODO: Opening the GUI causes an xrun, why? pub fn create_egui_editor( parent: EditorWindowHandle, size: Arc>, diff --git a/src/wrapper/vst3.rs b/src/wrapper/vst3.rs index d2e1f74f..04707cdb 100644 --- a/src/wrapper/vst3.rs +++ b/src/wrapper/vst3.rs @@ -1364,6 +1364,10 @@ impl IPlugView for WrapperView

{ } }; + // FIXME: On second thought, this needs some reworking. Needing a read lock on the + // plugin's object means that the process call (which requires a write lock) will + // be blocked. The better API will be to move the create function to the `Editor` + // struct, so we can already fetch that during initialization. *editor = self .inner .plugin