alex/nih-plug
1
0
Fork 0
Code Activity

Never compress the DC bin in SC

Browse source 
This just results in more problems than it solves for small window
sizes.
This commit is contained in:
Robbert van der Helm 2022-07-24 19:04:53 +02:00
parent 6b26828839
commit 42c42dff9b
1 changed files with 1 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
plugins/spectral_compressor/src/lib.rs
View file

@ -354,13 +354,6 @@ impl Plugin for SpectralCompressor {
let first_non_dc_bin_idx = let first_non_dc_bin_idx =
(20.0 / ((self.buffer_config.sample_rate / 2.0) / num_bins as f32)).floor() as usize (20.0 / ((self.buffer_config.sample_rate / 2.0) / num_bins as f32)).floor() as usize
+ 1; + 1;
// Never compress the first bin on larger window sizes even if the DC filter is disabled
let dont_compress_below_bin_idx = if self.params.global.dc_filter.value || window_size > 256
{
first_non_dc_bin_idx
} else {
0
};
// The overlap gain compensation is based on a squared Hann window, which will sum perfectly // The overlap gain compensation is based on a squared Hann window, which will sum perfectly
// at four times overlap or higher. We'll apply a regular Hann window before the analysis // at four times overlap or higher. We'll apply a regular Hann window before the analysis
@ -404,7 +397,7 @@ impl Plugin for SpectralCompressor {
channel_idx, channel_idx,
&self.params, &self.params,
overlap_times, overlap_times,
dont_compress_below_bin_idx, first_non_dc_bin_idx,
); );
// The DC and other low frequency bins doesn't contain much semantic meaning anymore // The DC and other low frequency bins doesn't contain much semantic meaning anymore