alex/nih-plug
1
0
Fork 0
Code Activity

Move smoothing scratch buffers to the heap

Browse source 
This is probably a good idea to keep the stack sizes small. A couple 32
element buffers should be fine, but these fit 512 elements each and
Windows can be fussy about stack sizes.
This commit is contained in:
Robbert van der Helm 2023-04-05 19:05:11 +02:00
parent d3f820dc8c
commit 4e0a0d4cd5
1 changed files with 39 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

49
plugins/aw_soft_vacuum/src/lib.rs
View file

@ -44,6 +44,33 @@ struct SoftVacuum {
hard_vacuum_processors: Vec<hard_vacuum::HardVacuum>, hard_vacuum_processors: Vec<hard_vacuum::HardVacuum>,
/// Oversampling for each channel. /// Oversampling for each channel.
oversamplers: Vec<oversampling::Lanczos3Oversampler>, oversamplers: Vec<oversampling::Lanczos3Oversampler>,
/// Scratch buffers that the smoothed parameters can be rendered to. Allocated on the heap
/// because Windows uses tiny stack sizes which may eventually cause problems in some hosts.
scratch_buffers: Box<ScratchBuffers>,
}
struct ScratchBuffers {
// These are for the Hard Vacuum parameters
drive: [f32; MAX_OVERSAMPLED_BLOCK_SIZE],
warmth: [f32; MAX_OVERSAMPLED_BLOCK_SIZE],
aura: [f32; MAX_OVERSAMPLED_BLOCK_SIZE],
// These are for the mix parameters
output_gain: [f32; MAX_OVERSAMPLED_BLOCK_SIZE],
dry_wet_ratio: [f32; MAX_OVERSAMPLED_BLOCK_SIZE],
}
impl Default for ScratchBuffers {
fn default() -> Self {
Self {
drive: [0.0; MAX_OVERSAMPLED_BLOCK_SIZE],
warmth: [0.0; MAX_OVERSAMPLED_BLOCK_SIZE],
aura: [0.0; MAX_OVERSAMPLED_BLOCK_SIZE],
output_gain: [0.0; MAX_OVERSAMPLED_BLOCK_SIZE],
dry_wet_ratio: [0.0; MAX_OVERSAMPLED_BLOCK_SIZE],
}
}
} }
// The parameters are the same as in the original plugin, except that they have different value // The parameters are the same as in the original plugin, except that they have different value
@ -180,6 +207,8 @@ impl Default for SoftVacuum {
hard_vacuum_processors: Vec::new(), hard_vacuum_processors: Vec::new(),
oversamplers: Vec::new(), oversamplers: Vec::new(),
scratch_buffers: Box::default(),
} }
} }
} }
@ -275,33 +304,33 @@ impl Plugin for SoftVacuum {
let upsampled_block_len = block_len * oversampling_times; let upsampled_block_len = block_len * oversampling_times;
// These are the parameters for the distortion algorithm // These are the parameters for the distortion algorithm
let mut drive = [0.0; MAX_OVERSAMPLED_BLOCK_SIZE]; let drive = &mut self.scratch_buffers.drive;
self.params self.params
.drive .drive
.smoothed .smoothed
.next_block(&mut drive, upsampled_block_len); .next_block(drive, upsampled_block_len);
let mut warmth = [0.0; MAX_OVERSAMPLED_BLOCK_SIZE]; let warmth = &mut self.scratch_buffers.warmth;
self.params self.params
.warmth .warmth
.smoothed .smoothed
.next_block(&mut warmth, upsampled_block_len); .next_block(warmth, upsampled_block_len);
let mut aura = [0.0; MAX_OVERSAMPLED_BLOCK_SIZE]; let aura = &mut self.scratch_buffers.aura;
self.params self.params
.aura .aura
.smoothed .smoothed
.next_block(&mut aura, upsampled_block_len); .next_block(aura, upsampled_block_len);
// And the general output mixing // And the general output mixing
let mut output_gain = [0.0; MAX_OVERSAMPLED_BLOCK_SIZE]; let output_gain = &mut self.scratch_buffers.output_gain;
self.params self.params
.output_gain .output_gain
.smoothed .smoothed
.next_block(&mut output_gain, upsampled_block_len); .next_block(output_gain, upsampled_block_len);
let mut dry_wet_ratio = [0.0; MAX_OVERSAMPLED_BLOCK_SIZE]; let dry_wet_ratio = &mut self.scratch_buffers.dry_wet_ratio;
self.params self.params
.dry_wet_ratio .dry_wet_ratio
.smoothed .smoothed
.next_block(&mut dry_wet_ratio, upsampled_block_len); .next_block(dry_wet_ratio, upsampled_block_len);
for (block_channel, (oversampler, hard_vacuum)) in block.into_iter().zip( for (block_channel, (oversampler, hard_vacuum)) in block.into_iter().zip(
self.oversamplers self.oversamplers