alex/nih-plug
1
0
Fork 0
Code Activity

Add a todo for fallback DPI scale detection

Browse source
This commit is contained in:
Robbert van der Helm 2022-04-27 19:26:39 +02:00
parent ae31e416c2
commit 4fb67a720b
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/wrapper/vst3/view.rs
View file

@ -457,6 +457,13 @@ impl<P: Vst3Plugin> IPlugView for WrapperView<P> {
impl<P: Vst3Plugin> IPlugViewContentScaleSupport for WrapperView<P> { impl<P: Vst3Plugin> IPlugViewContentScaleSupport for WrapperView<P> {
unsafe fn set_scale_factor(&self, factor: f32) -> tresult { unsafe fn set_scale_factor(&self, factor: f32) -> tresult {
// TODO: So apparently Ableton Live doesn't call this function. Right now we'll hardcode the
// default scale to 1.0 on Linux and Windows since we can't easily get the scale from
// baseview. A better alternative would be to do the fallback DPI scale detection
// within NIH-plug itself. Then we can still only use baseview's system scale policy
// on macOS and both the editor implementation and the wrappers would know about the
// correct scale.
// On macOS scaling is done by the OS, and all window sizes are in logical pixels // On macOS scaling is done by the OS, and all window sizes are in logical pixels
if cfg!(target_os = "macos") { if cfg!(target_os = "macos") {
nih_debug_assert_failure!("Ignoring host request to set explicit DPI scaling factor"); nih_debug_assert_failure!("Ignoring host request to set explicit DPI scaling factor");