alex/nih-plug
1
0
Fork 0
Code Activity

Add some more use path safety for the clap export

Browse source
This commit is contained in:
Robbert van der Helm 2022-02-28 15:48:26 +01:00
parent 7e505ff09b
commit 51d7532b87
1 changed files with 10 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/wrapper/clap.rs
View file

@ -14,19 +14,21 @@ macro_rules! nih_export_clap {
mod clap { mod clap {
// We don't need any special initialization or deinitialization handling // We don't need any special initialization or deinitialization handling
pub fn init(_plugin_path: *const ::std::os::raw::c_char) -> bool { pub fn init(_plugin_path: *const ::std::os::raw::c_char) -> bool {
eprintln!("Init!"); nih_log!("clap::init()");
true true
} }
pub fn deinit() { pub fn deinit() {
eprintln!("Deinit!"); nih_log!("clap::deinit()");
} }
pub fn get_factory( pub fn get_factory(
factory_id: *const ::std::os::raw::c_char, factory_id: *const ::std::os::raw::c_char,
) -> *const ::std::ffi::c_void { ) -> *const ::std::ffi::c_void {
eprintln!("get factory!! {factory_id:#?}"); nih_log!("clap::get_factory({:?})", unsafe {
::std::ffi::CStr::from_ptr(factory_id)
});
std::ptr::null() std::ptr::null()
} }
@ -40,12 +42,14 @@ macro_rules! nih_export_clap {
// These function pointers are marked as `extern "C"`but there's no reason why the symbols // These function pointers are marked as `extern "C"`but there's no reason why the symbols
// would need to be exported, so we need these transmutes // would need to be exported, so we need these transmutes
init: unsafe { init: unsafe {
::std::mem::transmute(clap::init as fn(*const ::std::os::raw::c_char) -> bool) ::std::mem::transmute(
self::clap::init as fn(*const ::std::os::raw::c_char) -> bool,
)
}, },
deinit: unsafe { ::std::mem::transmute(clap::deinit as fn()) }, deinit: unsafe { ::std::mem::transmute(self::clap::deinit as fn()) },
get_factory: unsafe { get_factory: unsafe {
::std::mem::transmute( ::std::mem::transmute(
clap::get_factory self::clap::get_factory
as fn(*const ::std::os::raw::c_char) -> *const ::std::ffi::c_void, as fn(*const ::std::os::raw::c_char) -> *const ::std::ffi::c_void,
) )
}, },