diff --git a/src/context.rs b/src/context.rs index 9dbbbdd2..93cec608 100644 --- a/src/context.rs +++ b/src/context.rs @@ -16,7 +16,7 @@ //! Different contexts the plugin can use to make callbacks to the host in different...contexts. -use std::sync::Arc; +use std::sync::Weak; use crate::params::Param; @@ -66,7 +66,7 @@ where { /// Create and start a new event loop. The thread this is called on will be designated as the /// main thread, so this should be called when constructing the wrapper. - fn new_and_spawn(executor: Arc) -> Self; + fn new_and_spawn(executor: Weak) -> Self; /// Either post the function to the task queue so it can be delegated to the main thread, or /// execute the task directly if this is the main thread. This function needs to be callable at diff --git a/src/context/linux.rs b/src/context/linux.rs index 906b475b..cefafb9c 100644 --- a/src/context/linux.rs +++ b/src/context/linux.rs @@ -19,7 +19,7 @@ //! delegate expensive processing to another thread. use crossbeam::channel; -use std::sync::Arc; +use std::sync::Weak; use std::thread::{self, JoinHandle, ThreadId}; use super::{EventLoop, MainThreadExecutor}; @@ -31,7 +31,7 @@ pub(crate) struct LinuxEventLoop { /// The thing that ends up executing these tasks. The tasks are usually executed from the worker /// thread, but if the current thread is the main thread then the task cna also be executed /// directly. - executor: Arc, + executor: Weak, /// The ID of the main thread. In practice this is the ID of the thread that created this task /// queue. @@ -59,7 +59,7 @@ where T: Send, E: MainThreadExecutor, { - fn new_and_spawn(executor: Arc) -> Self { + fn new_and_spawn(executor: Weak) -> Self { let (sender, receiver) = channel::bounded(super::TASK_QUEUE_CAPACITY); Self { @@ -83,8 +83,16 @@ where fn do_maybe_async(&self, task: T) -> bool { if self.is_main_thread() { - self.executor.execute(task); - true + match self.executor.upgrade() { + Some(e) => { + e.execute(task); + true + } + None => { + nih_log!("The executor doesn't exist but somehow it's still submitting tasks, this shouldn't be possible!"); + false + } + } } else { self.worker_thread_channel .try_send(Message::Task(task)) @@ -109,14 +117,20 @@ impl Drop for LinuxEventLoop { } /// The worker thread used in [EventLoop] that executes incmoing tasks on the event loop's executor. -fn worker_thread(receiver: channel::Receiver>, executor: Arc) +fn worker_thread(receiver: channel::Receiver>, executor: Weak) where T: Send, E: MainThreadExecutor, { loop { match receiver.recv() { - Ok(Message::Task(task)) => executor.execute(task), + Ok(Message::Task(task)) => match executor.upgrade() { + Some(e) => e.execute(task), + None => { + nih_log!("Received a new task but the executor is no longer alive, shutting down worker"); + return; + } + }, Ok(Message::Shutdown) => return, Err(err) => { nih_log!( diff --git a/src/wrapper/vst3.rs b/src/wrapper/vst3.rs index a7cec81f..25572a39 100644 --- a/src/wrapper/vst3.rs +++ b/src/wrapper/vst3.rs @@ -220,7 +220,7 @@ impl WrapperInner<'_, P> { // XXX: This unsafe block is unnecessary. rust-analyzer gets a bit confused and this this // `write()` function is from `IBStream` which it definitely is not. *unsafe { wrapper.event_loop.write() } = - MaybeUninit::new(OsEventLoop::new_and_spawn(wrapper.clone())); + MaybeUninit::new(OsEventLoop::new_and_spawn(Arc::downgrade(&wrapper))); wrapper }