alex/nih-plug
1
0
Fork 0
Code Activity

Rename from_string to set_from_string

Browse source 
To make it a bit more obvious at a glance that this mutates the
parameter.
This commit is contained in:
Robbert van der Helm 2022-01-29 13:32:31 +01:00
parent f5f143b4f0
commit 5697183918
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/params.rs
View file

@ -69,7 +69,7 @@ macro_rules! impl_plainparam {
/// can fail if the string cannot be parsed. /// can fail if the string cannot be parsed.
/// ///
/// TODO: After implementing VST3, check if we handle parsing failures correctly /// TODO: After implementing VST3, check if we handle parsing failures correctly
pub fn from_string(&mut self, string: &str) -> bool { pub fn set_from_string(&mut self, string: &str) -> bool {
let value = match &self.string_to_value { let value = match &self.string_to_value {
Some(f) => f(string), Some(f) => f(string),
// TODO: Check how Rust's parse function handles trailing garbage // TODO: Check how Rust's parse function handles trailing garbage
@ -240,10 +240,10 @@ impl ParamPtr {
/// ///
/// Calling this function is only safe as long as the object this `ParamPtr` was created for is /// Calling this function is only safe as long as the object this `ParamPtr` was created for is
/// still alive. /// still alive.
pub unsafe fn from_string(&mut self, string: &str) -> bool { pub unsafe fn set_from_string(&mut self, string: &str) -> bool {
match &self { match &self {
ParamPtr::FloatParam(p) => (**p).from_string(string), ParamPtr::FloatParam(p) => (**p).set_from_string(string),
ParamPtr::IntParam(p) => (**p).from_string(string), ParamPtr::IntParam(p) => (**p).set_from_string(string),
} }
} }