alex/nih-plug
1
0
Fork 0
Code Activity

Don't apply output gain to unfiltered DC bins

Browse source
This commit is contained in:
Robbert van der Helm 2022-08-20 16:53:33 +02:00
parent 14450da80a
commit 5b021da373
1 changed files with 10 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
plugins/spectral_compressor/src/lib.rs
View file

@ -110,7 +110,9 @@ pub struct GlobalParams {
#[id = "dry_wet"]
pub dry_wet_ratio: FloatParam,
/// Sets the 0-20 Hz bin to 0 since this won't have a lot of semantic meaning anymore after this
/// plugin and it will thus just eat up headroom.
/// plugin and it will thus just eat up headroom. If this option is disabled then the DC bins
/// will be gained by the reverse of the output gain to prevent them from getting louder as you
/// crank the output gain as makeup gain.
#[id = "dc_filter"]
pub dc_filter: BoolParam,
@ -526,10 +528,15 @@ fn process_stft_main(
first_non_dc_bin_idx,
);
// The DC and other low frequency bins doesn't contain much semantic meaning anymore
// after all of this, so it only ends up consuming headroom.
// The DC and other low frequency bins doesn't contain much semantic meaning anymore after all
// of this, so it only ends up consuming headroom. Otherwise they're gained down by the output
// gain to prevent makeup gain from making these bins too loud.
if params.global.dc_filter.value {
complex_fft_buffer[..first_non_dc_bin_idx].fill(Complex32::default());
} else {
for bin in complex_fft_buffer[..first_non_dc_bin_idx].iter_mut() {
*bin *= -output_gain;
}
}
// Inverse FFT back into the scratch buffer. This will be added to a ring buffer