From 6b7acb7cb5032b16a8d01ba2b2575b20809e35d7 Mon Sep 17 00:00:00 2001 From: Robbert van der Helm Date: Fri, 28 Jan 2022 17:55:18 +0100 Subject: [PATCH] Add TODO for wrapping parameter access in a mutex --- src/wrapper/vst3.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/wrapper/vst3.rs b/src/wrapper/vst3.rs index cbd1b681..da1b8e6c 100644 --- a/src/wrapper/vst3.rs +++ b/src/wrapper/vst3.rs @@ -89,6 +89,9 @@ pub struct Wrapper<'a, P: Plugin> { /// A mapping from parameter ID hashes (obtained from the string parameter IDs) to pointers to /// parameters belonging to the plugin. As long as `plugin` does not get recreated, these /// addresses will remain stable, as they are obtained from a pinned object. + /// + /// TODO: Wrap this in a mutex in case the host tries setting parameters from multiple threads + /// at the same time. param_by_hash: HashMap, /// The keys from `param_map` in a stable order. param_hashes: Vec,