From 76960e7e92b4a3474b12d8d6c2adb61a9dc345e2 Mon Sep 17 00:00:00 2001 From: Robbert van der Helm Date: Wed, 22 Mar 2023 13:49:59 +0100 Subject: [PATCH] Fix envelope follower timings getting stuck at 0ms Regression from f6ef95db3e220093eb40b16f3cd0cfa9762a2f40. --- plugins/spectral_compressor/CHANGELOG.md | 7 +++++++ plugins/spectral_compressor/src/compressor_bank.rs | 2 ++ 2 files changed, 9 insertions(+) diff --git a/plugins/spectral_compressor/CHANGELOG.md b/plugins/spectral_compressor/CHANGELOG.md index db1b84a5..99c0d2a3 100644 --- a/plugins/spectral_compressor/CHANGELOG.md +++ b/plugins/spectral_compressor/CHANGELOG.md @@ -6,6 +6,13 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). +## [Unreleased] + +### Fixed + +- Fixed a regression from version 0.4.0 that caused the envelope followers to + always be stuck at their fastest timings. + ## [0.4.0] - 2023-03-22 ### Added diff --git a/plugins/spectral_compressor/src/compressor_bank.rs b/plugins/spectral_compressor/src/compressor_bank.rs index c91f6f0d..0a3e6c03 100644 --- a/plugins/spectral_compressor/src/compressor_bank.rs +++ b/plugins/spectral_compressor/src/compressor_bank.rs @@ -693,6 +693,7 @@ impl CompressorBank { params.global.compressor_release_ms.value(), ) }; + self.envelopes_were_reset = false; // The coefficient the old envelope value is multiplied by when the current rectified sample // value is above the envelope's value. The 0 to 1 step response retains 36.8% of the old @@ -746,6 +747,7 @@ impl CompressorBank { params.global.compressor_release_ms.value(), ) }; + self.envelopes_were_reset = false; // See `update_envelopes()` let effective_sample_rate =