alex/nih-plug
1
0
Fork 0
Code Activity

Mention potential race condition in CLAP events

Browse source
This commit is contained in:
Robbert van der Helm 2022-03-11 14:33:43 +01:00
parent f98ba70764
commit 87e447ab25
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/wrapper/clap/context.rs
View file

@ -74,6 +74,10 @@ impl<P: ClapPlugin> GuiContext for WrapperGuiContext<P> {
Some(hash) => { Some(hash) => {
// Apparently you're supposed to resend old values for the automation begin and end // Apparently you're supposed to resend old values for the automation begin and end
// gestures // gestures
// FIXME: This will result in a race condition if the parameter is modified in the
// same cycle! (same for the gesture begin, but it's less likely to cause
// problems there) This will be fixed in a next version of CLAP by splitting
// the gestures up into their own events so it's not a huge deal right now.
let clap_plain_value = let clap_plain_value =
param.normalized_value() as f64 * param.step_count().unwrap_or(1) as f64; param.normalized_value() as f64 * param.step_count().unwrap_or(1) as f64;
let success = self.wrapper.queue_parameter_change(OutputParamChange { let success = self.wrapper.queue_parameter_change(OutputParamChange {