alex/nih-plug
1
0
Fork 0
Code Activity

Drop param_id_to_hash

Browse source 
As it turns out, it's redundant (and also had the opposite name).
This commit is contained in:
Robbert van der Helm 2022-01-31 22:23:29 +01:00
parent fe8f1d27d6
commit 880ee92a47
1 changed files with 4 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/wrapper/vst3.rs
View file

@ -120,10 +120,8 @@ struct WrapperInner<'a, P: Plugin> {
/// The default normalized parameter value for every parameter in `param_ids`. We need to store /// The default normalized parameter value for every parameter in `param_ids`. We need to store
/// this in case the host requeries the parmaeter later. /// this in case the host requeries the parmaeter later.
param_defaults_normalized: Vec<f32>, param_defaults_normalized: Vec<f32>,
/// Mappings from parameter hashes back to string parameter indentifiers. Useful for debug /// Mappings from string parameter indentifiers to parameter hashes. Useful for debug logging
/// logging and when handling plugin state. /// and when storing and restorign plugin state.
param_id_to_hash: HashMap<u32, &'static str>,
/// The inverse mapping from `param_id_hashes`. Used only for restoring state.
param_hash_to_id: HashMap<&'static str, u32>, param_hash_to_id: HashMap<&'static str, u32>,
} }
@ -174,8 +172,6 @@ impl<P: Plugin> WrapperInner<'_, P> {
HashMap::new(), HashMap::new(),
param_defaults_normalized: param_defaults_normalized:
Vec::new(), Vec::new(),
param_id_to_hash:
HashMap::new(),
param_hash_to_id: param_hash_to_id:
HashMap::new(), HashMap::new(),
}; };
@ -209,10 +205,6 @@ impl<P: Plugin> WrapperInner<'_, P> {
.clone() .clone()
.map(|(_, _, ptr)| unsafe { ptr.normalized_value() }) .map(|(_, _, ptr)| unsafe { ptr.normalized_value() })
.collect(); .collect();
wrapper.param_id_to_hash = param_id_hashes_ptrs
.clone()
.map(|(id, hash, _)| (hash, *id))
.collect();
wrapper.param_hash_to_id = param_id_hashes_ptrs wrapper.param_hash_to_id = param_id_hashes_ptrs
.map(|(id, hash, _)| (*id, hash)) .map(|(id, hash, _)| (*id, hash))
.collect(); .collect();
@ -499,9 +491,9 @@ impl<P: Plugin> IComponent for Wrapper<'_, P> {
// We'll serialize parmaeter values as a simple `string_param_id: display_value` map. // We'll serialize parmaeter values as a simple `string_param_id: display_value` map.
let mut params: HashMap<_, _> = self let mut params: HashMap<_, _> = self
.inner .inner
.param_id_to_hash .param_hash_to_id
.iter() .iter()
.filter_map(|(hash, param_id_str)| { .filter_map(|(param_id_str, hash)| {
let param_ptr = self.inner.param_by_hash.get(hash)?; let param_ptr = self.inner.param_by_hash.get(hash)?;
Some((param_id_str, param_ptr)) Some((param_id_str, param_ptr))
}) })