alex/nih-plug
1
0
Fork 0
Code Activity

Fix C++ interface pointer transmutes

Browse source 
These are supposed to be pointers to vtable pointers.
This commit is contained in:
Robbert van der Helm 2022-04-20 20:25:47 +02:00
parent 5d343f7873
commit 8966ca5280
1 changed files with 7 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
src/wrapper/vst3/view.rs
View file

@ -135,7 +135,8 @@ impl<P: Vst3Plugin> WrapperView<P> {
// The argument types are a bit wonky here because you can't construct a // The argument types are a bit wonky here because you can't construct a
// `SharedVstPtr`. This _should_ work however. // `SharedVstPtr`. This _should_ work however.
let plug_view: SharedVstPtr<dyn IPlugView> = mem::transmute(self.__iplugviewvptr); let plug_view: SharedVstPtr<dyn IPlugView> =
mem::transmute(&self.__iplugviewvptr as *const *const _);
let result = plug_frame.resize_view(plug_view, &mut size); let result = plug_frame.resize_view(plug_view, &mut size);
result == kResultOk result == kResultOk
@ -182,7 +183,6 @@ impl<P: Vst3Plugin> RunLoopEventHandler<P> {
); );
let [socket_read_fd, socket_write_fd] = sockets; let [socket_read_fd, socket_write_fd] = sockets;
// vst3-sys provides no way to convert to a SharedVstPtr, so, uh, yeah
let handler = RunLoopEventHandler::allocate( let handler = RunLoopEventHandler::allocate(
inner, inner,
run_loop, run_loop,
@ -190,8 +190,11 @@ impl<P: Vst3Plugin> RunLoopEventHandler<P> {
socket_write_fd, socket_write_fd,
ArrayQueue::new(TASK_QUEUE_CAPACITY), ArrayQueue::new(TASK_QUEUE_CAPACITY),
); );
// vst3-sys provides no way to convert to a SharedVstPtr, so, uh, yeah. These are pointers
// to vtable poitners.
let event_handler: SharedVstPtr<dyn IEventHandler> = let event_handler: SharedVstPtr<dyn IEventHandler> =
unsafe { mem::transmute(handler.__ieventhandlervptr) }; unsafe { mem::transmute(&handler.__ieventhandlervptr as *const *const _) };
assert_eq!( assert_eq!(
unsafe { unsafe {
handler handler
@ -508,7 +511,7 @@ impl<P: Vst3Plugin> Drop for RunLoopEventHandler<P> {
} }
let event_handler: SharedVstPtr<dyn IEventHandler> = let event_handler: SharedVstPtr<dyn IEventHandler> =
unsafe { mem::transmute(self.__ieventhandlervptr) }; unsafe { mem::transmute(&self.__ieventhandlervptr as *const _) };
unsafe { self.run_loop.unregister_event_handler(event_handler) }; unsafe { self.run_loop.unregister_event_handler(event_handler) };
} }
} }