From 89b81b38c338dc98b4c150c7f28d31dc2f8dee95 Mon Sep 17 00:00:00 2001
From: Robbert van der Helm <mail@robbertvanderhelm.nl>
Date: Tue, 31 Jan 2023 22:22:42 +0100
Subject: [PATCH] Remove debug assertions for SysEx parse failures
---
src/wrapper/clap/wrapper.rs | 5 +++--
src/wrapper/vst3/wrapper.rs | 7 +++----
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/src/wrapper/clap/wrapper.rs b/src/wrapper/clap/wrapper.rs
index cd06f731..fad200c8 100644
--- a/src/wrapper/clap/wrapper.rs
+++ b/src/wrapper/clap/wrapper.rs
@@ -1650,8 +1650,9 @@ impl<P: ClapPlugin> Wrapper<P> {
Ok(note_event) => {
input_events.push_back(note_event);
}
- // `NoteEvent::from_midi` contains more detailed tracing
- Err(_) => nih_debug_assert_failure!("Could not parse SysEx message"),
+ // `NoteEvent::from_midi` prints some tracing if parsing fails, which is not
+ // necessarily an error
+ Err(_) => (),
};
}
_ => {
diff --git a/src/wrapper/vst3/wrapper.rs b/src/wrapper/vst3/wrapper.rs
index 01eff8bc..ecc4f1fa 100644
--- a/src/wrapper/vst3/wrapper.rs
+++ b/src/wrapper/vst3/wrapper.rs
@@ -1235,10 +1235,9 @@ impl<P: Vst3Plugin> IAudioProcessor for Wrapper<P> {
Ok(note_event) => {
process_events.push(ProcessEvent::NoteEvent(note_event));
}
- Err(_) => {
- // `NoteEvent::from_midi` contains more detailed tracing
- nih_debug_assert_failure!("Could not parse SysEx message");
- }
+ // `NoteEvent::from_midi` prints some tracing if parsing fails,
+ // which is not necessarily an error
+ Err(_) => (),
};
}
}