From afde489bbfa268aeccc96bcaa8cd8fec4d10fe9a Mon Sep 17 00:00:00 2001 From: Robbert van der Helm Date: Wed, 27 Apr 2022 16:45:34 +0200 Subject: [PATCH] Add a fixme for REAPER's broken bypass handling --- src/wrapper/vst3/context.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/wrapper/vst3/context.rs b/src/wrapper/vst3/context.rs index f98ceca1..36a05f30 100644 --- a/src/wrapper/vst3/context.rs +++ b/src/wrapper/vst3/context.rs @@ -64,6 +64,9 @@ impl GuiContext for WrapperGuiContext

{ // the plugin is currently processing audio, the host will pass this change back // to the plugin in the audio callback. This also prevents the values from // changing in the middle of the process callback, which would be unsound. + // FIXME: So this doesn't work for REAPER, because they just silently stop + // processing audio when you bypass the plugin. Great. We can add a time + // based heuristic to work aorund this in the meantime. if !self.inner.is_processing.load(Ordering::SeqCst) { self.inner.set_normalized_value_by_hash( *hash,