alex/nih-plug
1
0
Fork 0
Code Activity

Don't store a GUID in the factory

Browse source 
This isn't actually needed.
This commit is contained in:
Robbert van der Helm 2022-02-07 00:19:05 +01:00
parent c9a5818cb4
commit ce37ec288e
1 changed files with 5 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
src/wrapper/vst3.rs
View file

@ -919,21 +919,13 @@ impl<P: Plugin> IAudioProcessor for Wrapper<P> {
#[doc(hidden)]
#[VST3(implements(IPluginFactory, IPluginFactory2, IPluginFactory3))]
pub struct Factory<P: Vst3Plugin> {
/// The exposed plugin's GUID. Instead of generating this, we'll just let the programmer decide
/// on their own.
cid: GUID,
/// The type will be used for constructing plugin instances later.
_phantom: PhantomData<P>,
}
impl<P: Vst3Plugin> Factory<P> {
pub fn new() -> Box<Self> {
Self::allocate(
GUID {
data: P::VST3_CLASS_ID,
},
PhantomData::default(),
)
Self::allocate(PhantomData::default())
}
}
@ -965,7 +957,7 @@ impl<P: Vst3Plugin> IPluginFactory for Factory<P> {
*info = mem::zeroed();
let info = &mut *info;
info.cid = self.cid;
info.cid.data = P::VST3_CLASS_ID;
info.cardinality = vst3_sys::base::ClassCardinality::kManyInstances as i32;
strlcpy(&mut info.category, "Audio Module Class");
strlcpy(&mut info.name, P::NAME);
@ -981,7 +973,7 @@ impl<P: Vst3Plugin> IPluginFactory for Factory<P> {
) -> tresult {
check_null_ptr!(cid, obj);
if *cid != self.cid {
if (*cid).data != P::VST3_CLASS_ID {
return kNoInterface;
}
@ -1004,7 +996,7 @@ impl<P: Vst3Plugin> IPluginFactory2 for Factory<P> {
*info = mem::zeroed();
let info = &mut *info;
info.cid = self.cid;
info.cid.data = P::VST3_CLASS_ID;
info.cardinality = vst3_sys::base::ClassCardinality::kManyInstances as i32;
strlcpy(&mut info.category, "Audio Module Class");
strlcpy(&mut info.name, P::NAME);
@ -1031,7 +1023,7 @@ impl<P: Vst3Plugin> IPluginFactory3 for Factory<P> {
*info = mem::zeroed();
let info = &mut *info;
info.cid = self.cid;
info.cid.data = P::VST3_CLASS_ID;
info.cardinality = vst3_sys::base::ClassCardinality::kManyInstances as i32;
strlcpy(&mut info.category, "Audio Module Class");
u16strlcpy(&mut info.name, P::NAME);