alex/nih-plug
1
0
Fork 0
Code Activity

Move Box creation to the CLAP wrapper

Browse source 
So the new->destroy pair makes more sense
This commit is contained in:
Robbert van der Helm 2022-03-03 15:01:28 +01:00
parent cd070ad876
commit d1840b8d86
2 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/wrapper/clap/factory.rs
View file

@ -60,7 +60,7 @@ impl<P: ClapPlugin> Factory<P> {
if !plugin_id.is_null() && CStr::from_ptr(plugin_id) == factory.plugin_descriptor.clap_id() if !plugin_id.is_null() && CStr::from_ptr(plugin_id) == factory.plugin_descriptor.clap_id()
{ {
&Box::leak(Box::new(Wrapper::<P>::new(host))).clap_plugin &Box::leak(Wrapper::<P>::new(host)).clap_plugin
} else { } else {
ptr::null() ptr::null()
} }

6
src/wrapper/clap/plugin.rs
View file

@ -105,7 +105,7 @@ pub struct Wrapper<P: ClapPlugin> {
/// and output channel counts if that does not match one of those configurations (to do the /// and output channel counts if that does not match one of those configurations (to do the
/// least surprising thing). /// least surprising thing).
/// ///
/// TODO: Support surround setups once a plugin needs taht /// TODO: Support surround setups once a plugin needs that
supported_bus_configs: Vec<BusConfig>, supported_bus_configs: Vec<BusConfig>,
clap_plugin_audio_ports: clap_plugin_audio_ports, clap_plugin_audio_ports: clap_plugin_audio_ports,
@ -214,7 +214,7 @@ impl<P: ClapPlugin> MainThreadExecutor<Task> for Wrapper<P> {
} }
impl<P: ClapPlugin> Wrapper<P> { impl<P: ClapPlugin> Wrapper<P> {
pub fn new(host_callback: *const clap_host) -> Self { pub fn new(host_callback: *const clap_host) -> Box<Self> {
let plugin_descriptor = Box::new(PluginDescriptor::default()); let plugin_descriptor = Box::new(PluginDescriptor::default());
assert!(!host_callback.is_null()); assert!(!host_callback.is_null());
@ -371,7 +371,7 @@ impl<P: ClapPlugin> Wrapper<P> {
.map(|(_, hash, ptr)| (*ptr, hash)) .map(|(_, hash, ptr)| (*ptr, hash))
.collect(); .collect();
wrapper Box::new(wrapper)
} }
fn make_process_context(&self) -> WrapperProcessContext<'_, P> { fn make_process_context(&self) -> WrapperProcessContext<'_, P> {