alex/nih-plug
1
0
Fork 0
Code Activity

Get rid of Default implementations for params

Browse source 
These don't make any sense anymore with the builder API.
This commit is contained in:
Robbert van der Helm 2022-05-01 17:36:22 +02:00
parent cd628e80ee
commit d6bdfd7391
4 changed files with 24 additions and 77 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

24
src/param/boolean.rs
View file

@ -34,22 +34,6 @@ pub struct BoolParam {
string_to_value: Option<Arc<dyn Fn(&str) -> Option<bool> + Send + Sync>>,
}
#[allow(clippy::derivable_impls)]
impl Default for BoolParam {
fn default() -> Self {
Self {
value: false,
normalized_value: 0.0,
default: false,
flags: ParamFlags::default(),
value_changed: None,
name: String::new(),
value_to_string: None,
string_to_value: None,
}
}
}
impl Display for BoolParam {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
match (self.value, &self.value_to_string) {
@ -165,9 +149,15 @@ impl BoolParam {
pub fn new(name: impl Into<String>, default: bool) -> Self {
Self {
value: default,
normalized_value: if default { 1.0 } else { 0.0 },
default,
flags: ParamFlags::default(),
value_changed: None,
name: name.into(),
..Default::default()
value_to_string: None,
string_to_value: None,
}
}

21
src/param/enums.rs
View file

@ -65,27 +65,6 @@ pub struct EnumParamInner {
variants: &'static [&'static str],
}
impl<T: Enum + PartialEq + Default> Default for EnumParam<T> {
fn default() -> Self {
let variants = T::variants();
Self {
inner: EnumParamInner {
inner: IntParam::new(
"",
T::default().to_index() as i32,
IntRange::Linear {
min: 0,
max: variants.len() as i32 - 1,
},
),
variants,
},
_marker: PhantomData,
}
}
}
impl<T: Enum + PartialEq> Display for EnumParam<T> {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
self.inner.fmt(f)

29
src/param/float.rs
View file

@ -65,25 +65,6 @@ pub struct FloatParam {
string_to_value: Option<Arc<dyn Fn(&str) -> Option<f32> + Send + Sync>>,
}
impl Default for FloatParam {
fn default() -> Self {
Self {
value: 0.0,
normalized_value: 0.0,
default: 0.0,
smoothed: Smoother::none(),
flags: ParamFlags::default(),
value_changed: None,
range: FloatRange::default(),
step_size: None,
name: String::new(),
unit: "",
value_to_string: None,
string_to_value: None,
}
}
}
impl Display for FloatParam {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
match (&self.value_to_string, &self.step_size) {
@ -235,9 +216,17 @@ impl FloatParam {
value: default,
normalized_value: range.normalize(default),
default,
smoothed: Smoother::none(),
flags: ParamFlags::default(),
value_changed: None,
range,
step_size: None,
name: name.into(),
..Default::default()
unit: "",
value_to_string: None,
string_to_value: None,
}
}

27
src/param/integer.rs
View file

@ -61,24 +61,6 @@ pub struct IntParam {
string_to_value: Option<Arc<dyn Fn(&str) -> Option<i32> + Send + Sync>>,
}
impl Default for IntParam {
fn default() -> Self {
Self {
value: 0,
normalized_value: 0.0,
default: 0,
smoothed: Smoother::none(),
flags: ParamFlags::default(),
value_changed: None,
range: IntRange::default(),
name: String::new(),
unit: "",
value_to_string: None,
string_to_value: None,
}
}
}
impl Display for IntParam {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
match &self.value_to_string {
@ -199,9 +181,16 @@ impl IntParam {
value: default,
normalized_value: range.normalize(default),
default,
smoothed: Smoother::none(),
flags: ParamFlags::default(),
value_changed: None,
range,
name: name.into(),
..Default::default()
unit: "",
value_to_string: None,
string_to_value: None,
}
}