From dedbfebb714cfae6aa3a35a39902960d07bd6611 Mon Sep 17 00:00:00 2001 From: Robbert van der Helm Date: Tue, 26 Apr 2022 14:15:57 +0200 Subject: [PATCH] Add todos about potential duplicate reset calls --- src/wrapper/clap/wrapper.rs | 3 +++ src/wrapper/vst3/wrapper.rs | 3 +++ 2 files changed, 6 insertions(+) diff --git a/src/wrapper/clap/wrapper.rs b/src/wrapper/clap/wrapper.rs index 95e96385..2e991879 100644 --- a/src/wrapper/clap/wrapper.rs +++ b/src/wrapper/clap/wrapper.rs @@ -2620,6 +2620,9 @@ impl Wrapper

{ &buffer_config, &mut wrapper.make_process_context(Transport::new(buffer_config.sample_rate)), ); + // TODO: This also goes for the VST3 version, but should we call reset here? Won't the + // host always restart playback? Check this with a couple of hosts and remove the + // duplicate reset if it's not needed. process_wrapper(|| plugin.reset()); } diff --git a/src/wrapper/vst3/wrapper.rs b/src/wrapper/vst3/wrapper.rs index a34dd17c..80a43a19 100644 --- a/src/wrapper/vst3/wrapper.rs +++ b/src/wrapper/vst3/wrapper.rs @@ -298,6 +298,9 @@ impl IComponent for Wrapper

{ .inner .make_process_context(Transport::new(buffer_config.sample_rate)), ); + // TODO: This also goes for the CLAP version, but should we call reset here? Won't the + // host always restart playback? Check this with a couple of hosts and remove the + // duplicate reset if it's not needed. process_wrapper(|| plugin.reset()); }