alex/nih-plug
1
0
Fork 0
Code Activity

Add comments for potential parameter quirks

Browse source
This commit is contained in:
Robbert van der Helm 2022-03-01 02:15:23 +01:00
parent 5f1ebca6e6
commit e5edbac2b4
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/wrapper/clap/plugin.rs
View file

@ -395,10 +395,14 @@ impl<P: ClapPlugin> Wrapper<P> {
param_info.cookie = ptr::null_mut(); param_info.cookie = ptr::null_mut();
strlcpy(&mut param_info.name, param_ptr.name()); strlcpy(&mut param_info.name, param_ptr.name());
strlcpy(&mut param_info.module, ""); strlcpy(&mut param_info.module, "");
// We don't use the actual minimum and maximum values here because that would not scale
// with skewed integer ranges. Instead, just treat all parameters as `[0, 1]` normalized
// paramters multiplied by the step size.
param_info.min_value = 0.0; param_info.min_value = 0.0;
// Stepped parameters are unnormalized float parameters since there's no separate step // Stepped parameters are unnormalized float parameters since there's no separate step
// range option // range option
// TODO: This should probably be encapsulated in some way so we don't forget about this in one place // TODO: This should probably be encapsulated in some way so we don't forget about this in one place
// TODO: Like with VST3, this won't actually do the correct thing with skewed stepped parameters
param_info.max_value = step_count.unwrap_or(1) as f64; param_info.max_value = step_count.unwrap_or(1) as f64;
param_info.default_value = *default_value as f64 * step_count.unwrap_or(1) as f64; param_info.default_value = *default_value as f64 * step_count.unwrap_or(1) as f64;
} }
@ -423,9 +427,9 @@ impl<P: ClapPlugin> Wrapper<P> {
} else { } else {
0.0 0.0
}; };
true true
} else if let Some(param_ptr) = wrapper.param_by_hash.get(&param_id) { } else if let Some(param_ptr) = wrapper.param_by_hash.get(&param_id) {
// TODO: As explained above, this may do strange things with skewed discrete parameters
*value = *value =
param_ptr.normalized_value() as f64 * param_ptr.step_count().unwrap_or(1) as f64; param_ptr.normalized_value() as f64 * param_ptr.step_count().unwrap_or(1) as f64;
true true

2
src/wrapper/vst3/wrapper.rs
View file

@ -433,6 +433,8 @@ impl<P: Vst3Plugin> IEditController for Wrapper<P> {
u16strlcpy(&mut info.title, param_ptr.name()); u16strlcpy(&mut info.title, param_ptr.name());
u16strlcpy(&mut info.short_title, param_ptr.name()); u16strlcpy(&mut info.short_title, param_ptr.name());
u16strlcpy(&mut info.units, param_ptr.unit()); u16strlcpy(&mut info.units, param_ptr.unit());
// TODO: The host assumes these steps are distirbuted linearly, so this may cause weird
// behavior with skewed integers
info.step_count = param_ptr.step_count().unwrap_or(0); info.step_count = param_ptr.step_count().unwrap_or(0);
info.default_normalized_value = *default_value as f64; info.default_normalized_value = *default_value as f64;
info.unit_id = vst3_sys::vst::kRootUnitId; info.unit_id = vst3_sys::vst::kRootUnitId;