alex/nih-plug
1
0
Fork 0
Code Activity

Handle 0 attack and release

Browse source
This commit is contained in:
Robbert van der Helm 2022-07-22 20:11:15 +02:00
parent dae9dc758c
commit ef3a7a76d5
1 changed files with 14 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
plugins/spectral_compressor/src/compressor_bank.rs
View file

@ -315,7 +315,6 @@ impl CompressorBankParams {
"Attack", "Attack",
150.0, 150.0,
FloatRange::Skewed { FloatRange::Skewed {
// TODO: Make sure to handle 0 attack and release times in the compressor
min: 0.0, min: 0.0,
max: 10_000.0, max: 10_000.0,
factor: FloatRange::skew_factor(-2.0), factor: FloatRange::skew_factor(-2.0),
@ -468,15 +467,22 @@ impl CompressorBank {
// for every 512 samples. // for every 512 samples.
let effective_sample_rate = let effective_sample_rate =
self.sample_rate / (self.window_size as f32 / overlap_times as f32); self.sample_rate / (self.window_size as f32 / overlap_times as f32);
let attack_old_t = (compressor.compressor_attack_ms.value / 1000.0 * effective_sample_rate) let attack_old_t = if compressor.compressor_attack_ms.value == 0.0 {
0.0
} else {
(compressor.compressor_attack_ms.value / 1000.0 * effective_sample_rate)
.recip() .recip()
.exp(); .exp()
};
let attack_new_t = 1.0 - attack_old_t; let attack_new_t = 1.0 - attack_old_t;
// The same as `attack_old_t`, but for the release phase of the envelope follower // The same as `attack_old_t`, but for the release phase of the envelope follower
let release_old_t = (compressor.compressor_release_ms.value / 1000.0 let release_old_t = if compressor.compressor_release_ms.value == 0.0 {
* effective_sample_rate) 0.0
} else {
(compressor.compressor_release_ms.value / 1000.0 * effective_sample_rate)
.recip() .recip()
.exp(); .exp()
};
let release_new_t = 1.0 - release_old_t; let release_new_t = 1.0 - release_old_t;
for (bin, envelope) in buffer for (bin, envelope) in buffer