alex/nih-plug
1
0
Fork 0
Code Activity
1812 commits 1 branch 0 tags 4.3 MiB
Commit graph

1812 commits

This branch
This branch
All branches
Author SHA1 Message Date
Robbert van der Helm 7f12c9f362 Fix group->unit conversion with missing parents 
This caused Spectral Compressor's VST3 version to not work because the
compressor group didn't contain any parameters.
 2022-07-24 23:37:45 +02:00
Robbert van der Helm fdbff129f8 Use linear gain params in gain examples 
Using the new skewed coefficient calculation function for gain ranges
from a couple commits ago.

Closes #18.
 2022-07-24 21:21:13 +02:00
Robbert van der Helm 6a1395e99a Avoid printing -0.0 dB 2022-07-24 21:20:53 +02:00
Robbert van der Helm 6ee7e8f4e3 Assert correct values for gain_skew_factor 2022-07-24 21:06:26 +02:00
Robbert van der Helm 2d3b601555 Allow comparisons in nih_assert!() 2022-07-24 21:06:13 +02:00
Robbert van der Helm 7b66145e8b Use correct gain skew factor for Safety Limiter 2022-07-24 20:48:13 +02:00
Robbert van der Helm e20b10d601 Store SC output gain as linear gain 
Using the new conversion function.
 2022-07-24 20:46:49 +02:00
Robbert van der Helm 44b9a4cad0 Add a way to compute skew factors for linear gain 
Needed for #18.
 2022-07-24 20:46:18 +02:00
Robbert van der Helm 42c42dff9b Never compress the DC bin in SC 
This just results in more problems than it solves for small window
sizes.
 2022-07-24 19:04:53 +02:00
Robbert van der Helm 6b26828839 Default both offsets to 0 dB again 
Otherwise the UI just looks weird.
 2022-07-24 19:01:28 +02:00
Robbert van der Helm 692b1051ad Avoid compressing DC bin on larger windows 
Even if the DC filter is disabled. We do want to compress this on
smaller windows as it covers the entire bass range.
 2022-07-24 18:39:04 +02:00
Robbert van der Helm 2a464c478c Default SC global threshold to 0 dBFS 2022-07-24 18:30:20 +02:00
Robbert van der Helm ce0aa0079c Slightly lower the threshold parameter 2022-07-24 18:26:57 +02:00
Robbert van der Helm ce72dc5f03 Fix disabled DC filter behavior 
This fixes a NaN from taking the logarithm of zero, and the lower bins
are not actually compressed when this option is disabled. This is useful
when using tiny window sizes as the first bin will span quite a chunk of
the spectrum.
 2022-07-24 18:25:46 +02:00
Robbert van der Helm 74b33af7d7 Fix DC bin skipping being off by one 2022-07-24 18:00:15 +02:00
Robbert van der Helm dffc169c99 Skew slope and curve more towards 0 
Especially positive curve values can get out of hand quick
 2022-07-24 17:48:02 +02:00
Robbert van der Helm d53d03c5cf Default downwards hi-freq rolloff to 0.25 
Sort of makes sense to have these two be symmetrical
 2022-07-24 17:43:31 +02:00
Robbert van der Helm 22dcbdf4a9 Make the default parameters a bit more gentle 2022-07-24 17:25:58 +02:00
Robbert van der Helm c06b134e93 Show the upwards parameter on the left 
It makes more sense this way.
 2022-07-24 17:17:28 +02:00
Robbert van der Helm 126cf3b141 Add a disclaimer to the GUI 
Because there's a good chance things will change later and patches may
not sound exactly the same anymore.
 2022-07-24 17:13:09 +02:00
Robbert van der Helm 0b1d9b60db Also skew the slope parameter 2022-07-24 17:07:35 +02:00
Robbert van der Helm 3fe1769a43 Change the global threshold range 
This should go lower and it doesn't need to exceed much past 0
dBFS (since full 0 dBFS in the frequency domain will peak pretty hard in
the time domain).
 2022-07-24 17:06:20 +02:00
Robbert van der Helm 4a2373b664 Implement upwards compression 2022-07-24 16:56:01 +02:00
Robbert van der Helm 8ca66cf9bb Move the main threshold up in the list 2022-07-24 16:29:50 +02:00
Robbert van der Helm 455ab0364a Skew the threshold curve parameter 
Since the center values will be most interesting useful range.
 2022-07-24 16:24:31 +02:00
Robbert van der Helm 068549607d Add soft-knee downwards compression 2022-07-24 15:58:30 +02:00
Robbert van der Helm 08201d2a87 Compute knee starts and ends 2022-07-24 15:54:58 +02:00
Robbert van der Helm 92f03e768f Default the rolloff parameters to 0 2022-07-24 15:15:47 +02:00
Robbert van der Helm b3166e3977 Rearrange Spectral Compressor GUI into 4x4 grid 2022-07-24 15:15:47 +02:00
Robbert van der Helm 7b02217ad4 Map from the Params object in GenericUi 
Otherwise reactivity doesn't work.
 2022-07-24 15:15:47 +02:00
Robbert van der Helm 8ae93cc6ab Remove Copy bound on ParamSlider 2022-07-24 15:15:47 +02:00
Robbert van der Helm f812374ad0 Make it easier to reuse generic UI widget drawing 2022-07-24 15:15:47 +02:00
Robbert van der Helm 4f62ebd2ea Wrap nested Params structs in Arcs 
So we can use the generic UIs. Vizia needs these to be 'static.
 2022-07-24 15:15:47 +02:00
Robbert van der Helm 2fbf4ca00d Remove Copy requirement from Vizia generic UI 
This now uses a dummy lens to map to the parameter.
 2022-07-24 15:15:47 +02:00
Robbert van der Helm 4327828e6b Move the Params implementation to CompressorParams 
So now CompressorBankParams can just derive Params.
 2022-07-24 15:15:47 +02:00
Robbert van der Helm dc97fb1019 Implement Params for Arc<P: Params> 
This is useful for partial generic UIs.
 2022-07-24 15:15:47 +02:00
Robbert van der Helm 278ae227a7 Make the Spectral Compressor editor a bit wider 
Next up is splitting this up in four generic UI panes to make it a bit
easier to use. That was why all of the previous commits moved parameters
around.
 2022-07-24 15:15:47 +02:00
Robbert van der Helm 6ae1c55f76 Deduplicate compressors with custom Params impl 
This now also finally serves as an example on how to do this.
 2022-07-24 15:15:47 +02:00
Robbert van der Helm fa392e61f1 Move attack and release to global parameters 2022-07-24 15:15:47 +02:00
Robbert van der Helm 3c1a1c8f14 Move global parameters to their own struct 
We'll temporarily split the generic UI into four panes to make it a bit
easier to use.
 2022-07-24 15:15:47 +02:00
Robbert van der Helm c53726bf9e Move the global threshold down in the list 2022-07-24 15:15:47 +02:00
Robbert van der Helm 06694683d3 Move the frequency center parameter down 
Somehow this is always where I'm looking for it.
 2022-07-24 15:15:47 +02:00
Robbert van der Helm 7db5da7930 Make the slope parameter range wider 2022-07-24 15:15:47 +02:00
Robbert van der Helm f58e278c85 Fix offsets in threshold calculations 2022-07-24 15:15:47 +02:00
Robbert van der Helm f0efdad059 Rearrange Spectral Compressor parameters 2022-07-24 15:15:47 +02:00
Robbert van der Helm 332ac2b231 Add basic hard-knee downwards compression 2022-07-24 15:15:47 +02:00
Robbert van der Helm faec0e35af Allow more granular ratios 2022-07-24 15:15:47 +02:00
Robbert van der Helm 43f86bcc85 Prevent threshold from reaching zero 2022-07-24 15:15:47 +02:00
Robbert van der Helm 8fbdc43ce3 Fix the high frequency rolloff 2022-07-24 15:15:47 +02:00
Robbert van der Helm eda842c6a9 Fix the envelope coefficients 
The minus was missing here.
 2022-07-24 15:15:47 +02:00