Robbert van der Helm
cdeb244202
Merge branch 'conditional-vst-feature' #55
...
Add missing conditions related to the "vst3" feature
https://github.com/robbert-vdh/nih-plug/pull/56
2023-02-19 13:12:26 +01:00
Viktor Lazarerv
5a08c27437
Add missing conditions related to the "vst3" feature
2023-02-12 16:30:52 +01:00
Robbert van der Helm
3e4aec4dfe
Document missing missing values in NoteEvent
2023-02-08 03:07:13 +01:00
Robbert van der Helm
d2b25f8682
Add missing debug assertions for VST3 callback
2023-02-06 18:00:33 +01:00
Robbert van der Helm
0abfcb6045
Add a ParamButton name override modifier
2023-02-02 20:03:54 +01:00
Robbert van der Helm
bea1a6028b
Remove unnecessary cast
2023-02-02 20:03:43 +01:00
Robbert van der Helm
32f981b1f6
Fix Buffr Glitch for crossfade lengths of 1 sample
2023-02-02 16:27:43 +01:00
Robbert van der Helm
9c48e7f59b
Fix assertion failures when reactivating plugins
...
`.set_slices()` makes sure all slices' lengths are equal to the first
argument, so in these functions we'll need to manually overwrite any
existing element with empty slices.
2023-02-02 16:15:43 +01:00
Robbert van der Helm
d7cefcd29a
Fix typos
2023-02-01 19:03:50 +01:00
Robbert van der Helm
62f7f38a9e
Loosen generic bounds on NoteEvent
...
The `S: SysExMessage` isn't strictly needed. I thought it might make the
usage clearer, but it does introduce more boilerplate than strictly
necessary when working with note events.
2023-02-01 18:07:45 +01:00
Robbert van der Helm
15128edde4
Fix assertions in clamping functions
...
This was previously comparing against the buffer's length, so the `<`
made sense. But this approach always allows events at time 0 even if the
buffer is empty.
2023-02-01 17:39:08 +01:00
Robbert van der Helm
d735d23ffa
Document the use of .saturating_sub(1)
2023-02-01 17:36:25 +01:00
Robbert van der Helm
55c3701d2e
Move event timing clamping to functions
...
So this doesn't need to be repeated everywhere.
2023-02-01 17:33:14 +01:00
Robbert van der Helm
d5a8eb42ec
Clamp event timings for VST3 plugins
2023-02-01 17:24:22 +01:00
Robbert van der Helm
eac88c4477
Clamp event times for JACK standalones
2023-02-01 17:18:06 +01:00
Robbert van der Helm
8d2d293b49
Clamp event timings for CLAP plugins
2023-02-01 17:17:50 +01:00
Robbert van der Helm
5cb826725d
Fix typo in docstring
2023-02-01 17:02:34 +01:00
Robbert van der Helm
7874e1796f
Add a debug assert for the subcategory length
...
Since this will be truncated otherwise.
2023-02-01 16:50:48 +01:00
Robbert van der Helm
d6184ea06e
Replace VST3 category string with enum slice
...
I've been putting this off for a while, but now is finally the day. We
already did this for CLAP a while back. This is both simpler and less
error prone.
2023-02-01 16:09:03 +01:00
Robbert van der Helm
7fe339987a
Define an enum for VST3 subcategories
...
Because looking these up and inputting them by hand every time is both
cumbersome and error prone.
2023-02-01 15:46:28 +01:00
Robbert van der Helm
5db07090ca
Replace match with if-let
...
Clippy didn't like this.
2023-02-01 14:52:45 +01:00
Robbert van der Helm
fba2c47614
Add a SysEx example plugin
2023-02-01 14:52:01 +01:00
Robbert van der Helm
e3a7e4a931
Allow any audio setup for midi_inverter
2023-02-01 14:39:47 +01:00
Robbert van der Helm
fb29322b81
Document which CLAP features are main categories
2023-02-01 14:36:54 +01:00
Robbert van der Helm
3790a05891
Avoid sending zero velocity note ons with MIDI
2023-02-01 12:48:51 +01:00
Robbert van der Helm
69b87b7a26
Print unhandled SysEx as hexadecimal
2023-01-31 22:25:23 +01:00
Robbert van der Helm
89b81b38c3
Remove debug assertions for SysEx parse failures
2023-01-31 22:22:42 +01:00
Robbert van der Helm
6e6f327dc4
Always accept MIDI events in CLAP
...
Otherwise we may not receive SysEx events.
2023-01-31 22:20:48 +01:00
Robbert van der Helm
5dbc76ef69
Simplify conversion from SysExMessage to buffers
...
There's no need to provide this as an argument anymore.
2023-01-31 22:03:40 +01:00
Robbert van der Helm
0deb8ab1cd
Simplify VST3 ProcessEvent::NoteEvent
2023-01-31 21:55:26 +01:00
Robbert van der Helm
b35914bbbd
Add SysEx support for VST3
2023-01-31 21:52:21 +01:00
Robbert van der Helm
e7be5ef178
Simplify CLAP SysEx output
2023-01-31 21:50:49 +01:00
Robbert van der Helm
701590f1cd
Support SysEx for CLAP plugins
2023-01-31 21:35:52 +01:00
Robbert van der Helm
868228f7b7
Add tests for SysEx parsing
2023-01-31 21:18:55 +01:00
Robbert van der Helm
ee24e14829
Log unhandled SysEx message in debug mode
2023-01-31 21:11:01 +01:00
Robbert van der Helm
8d9ae19d38
Support receiving SysEx in JACK standalone
2023-01-31 20:39:15 +01:00
Robbert van der Helm
68d68c0bc3
Add NoteEvent conversions to and from MIDI SysEx
...
JACK already supports this because otherwise things wouldn't compile,
but support still needs to be added for CLAP and VST3.
2023-01-31 20:37:33 +01:00
Robbert van der Helm
1e8bdb9d8e
Document the expected buffer format for SysEx
2023-01-31 19:29:11 +01:00
Robbert van der Helm
611dc452ec
Add conversion functions on SysExMessage trait
2023-01-31 18:57:49 +01:00
Robbert van der Helm
d9cf78e72a
Document the MidiSysEx event's availability
2023-01-31 18:45:30 +01:00
Robbert van der Helm
b7849f9a7a
Add a NoteEvent::MidiSysEx variant
...
Right now this isn't used, and there is not yet any way to convert to
and from raw SysEx data.
2023-01-31 18:32:16 +01:00
Robbert van der Helm
c8ed795524
Add a SysExMessage type to Plugin
...
This is needed to enable sending and receiving SysEx #54 . Because
associated type defaults still are not stable, this requires every
plugin that doesn't need this to set this to the unit type:
```rust
type SysExMessage = ();
```
2023-01-31 18:18:41 +01:00
Robbert van der Helm
978d466019
Add trait bounds for the SysExMessage trait
2023-01-31 18:18:41 +01:00
Robbert van der Helm
c828dabb03
Add a default implementation for SysExMessage
2023-01-31 17:45:23 +01:00
Robbert van der Helm
d6b5342c53
Add boilerplate for a SysEx message trait
2023-01-31 17:43:52 +01:00
Robbert van der Helm
683c96bca0
Avoid duplicate parameter callbacks and smoothing
...
REAPER seems to spam value set events when an automation lane is active,
and it also always sends CLAP automation events twice.
2023-01-31 16:31:29 +01:00
Robbert van der Helm
efff43df21
Add an StftHelper::max_padding()
2023-01-30 02:16:03 +01:00
Robbert van der Helm
e3e2a2e7d0
Actually change padding in StftHelper::set_padding
2023-01-30 01:55:34 +01:00
Robbert van der Helm
32957c222f
Add a missing category feature to the sine example
2023-01-28 23:23:56 +01:00
Robbert van der Helm
161c97bb28
Add the CLAP note detector feature
2023-01-28 23:23:56 +01:00
