alex/portability
1
0
Fork 0
mirror of https://github.com/italicsjenga/portability.git synced 2025-02-17 06:37:43 +11:00
Code Issues Projects Releases Packages Wiki Activity

Fix stack corruption caused by command buffers

Browse source 
Command buffer size needs to match between exposed type in Rust and vulkan declaration. Therefore, cmd buffers get wrapped in handles
This commit is contained in:
msiglreith 2017-11-23 00:04:29 +01:00
parent 7d45552cbc
commit ca1ff277fa
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/lib.rs
View file

@ -466,7 +466,7 @@ pub type VkInstance = Handle<back::Instance>;
pub type VkPhysicalDevice = Handle<hal::Adapter<B>>;
pub type VkDevice = Handle<hal::Gpu<B>>;
pub type VkCommandPool = Handle<<B as hal::Backend>::CommandPool>;
pub type VkCommandBuffer = <B as hal::Backend>::CommandBuffer;
pub type VkCommandBuffer = Handle<<B as hal::Backend>::CommandBuffer>;
#[repr(C)]
#[derive(Debug, Copy, Clone)]
@ -4915,7 +4915,7 @@ pub extern fn vkAllocateCommandBuffers(
slice::from_raw_parts_mut(pCommandBuffers, count)
};
for (out, cmd_buf) in output.iter_mut().zip(cmd_bufs) {
*out = cmd_buf;
*out = Handle::new(cmd_buf);
}
VkResult::VK_SUCCESS
@ -4931,7 +4931,10 @@ pub extern fn vkFreeCommandBuffers(
let buffer_slice = unsafe {
slice::from_raw_parts(pCommandBuffers, commandBufferCount as _)
};
let buffers = buffer_slice.to_vec();
let buffers = buffer_slice
.iter()
.map(|buffer| *buffer.unwrap())
.collect();
unsafe { commandPool.free(buffers) };
}