alex/portability
1
0
Fork 0
mirror of https://github.com/italicsjenga/portability.git synced 2024-11-29 18:31:31 +11:00
Code Issues Packages Projects Releases Wiki Activity

Merge #201

Browse source 
201: fixes crash when enumerating on some systems r=kvark a=Hugobros3

Was crashing when calling `vulkaninfo`. I did some digging:

In gfxEnumeratePhysicalDevices, there is some logic for dealing with the cases where the slots allocated by the caller aren't enough to fit all the adapters the implementation has available. This logic has a flaw though, because it doesn't account for the cases where `num_output` is greater than the numbers of adapters gfx has to offer, and in that case the output is oversized wrt to the adapters we have to fit inside.

This matches both sides for calling copy_from_slice in that function. Not sure why this happens, I have a proper vulkan-ready device in this computer with a "proper" driver too, which may or may not explain it ? I'm not knowledgeable enough on how the loader and everything works to make a definitive statement. 

This made things work on my pc so ¯\\_(ツ)_/¯

Co-authored-by: Gobrosse <hugo@xol.io>
This commit is contained in:
bors[bot] 2019-10-11 14:47:36 +00:00 committed by GitHub
parent 9926fe0729 50a59c91de
commit eac7f6b477
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
libportability-gfx/src/impls.rs
View file

@ -164,7 +164,7 @@ pub extern "C" fn gfxEnumeratePhysicalDevices(
(VkResult::VK_SUCCESS, num_adapters) (VkResult::VK_SUCCESS, num_adapters)
}; };
output.copy_from_slice(&instance.adapters[..count]); output[..count].copy_from_slice(&instance.adapters[..count]);
unsafe { *pPhysicalDeviceCount = count as _ }; unsafe { *pPhysicalDeviceCount = count as _ };
code code