From 711c0230b1923492bc9bd8c9614a41e92d2070cc Mon Sep 17 00:00:00 2001
From: Andrea Nall <anall@andreanall.com>
Date: Fri, 2 Jul 2021 11:28:56 -0500
Subject: [PATCH] fix minor issues

---
 rp2040-hal/src/gpio/dynpin.rs | 2 --
 rp2040-hal/src/gpio/pin.rs    | 2 +-
 rp2040-hal/src/gpio/reg.rs    | 2 +-
 3 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/rp2040-hal/src/gpio/dynpin.rs b/rp2040-hal/src/gpio/dynpin.rs
index 471bbc0..a5eb1f7 100644
--- a/rp2040-hal/src/gpio/dynpin.rs
+++ b/rp2040-hal/src/gpio/dynpin.rs
@@ -415,12 +415,10 @@ impl DynPin {
         Ok(self._read()? == true)
     }
     #[inline]
-    #[allow(clippy::bool_comparison)] // more explicit this way
     fn _set_low(&mut self) -> Result<(), Error> {
         self._write(false)
     }
     #[inline]
-    #[allow(clippy::bool_comparison)] // more explicit this way
     fn _set_high(&mut self) -> Result<(), Error> {
         self._write(true)
     }
diff --git a/rp2040-hal/src/gpio/pin.rs b/rp2040-hal/src/gpio/pin.rs
index c6561e4..a756bca 100644
--- a/rp2040-hal/src/gpio/pin.rs
+++ b/rp2040-hal/src/gpio/pin.rs
@@ -17,7 +17,7 @@
 //! Type-level [`Pin`]s are parameterized by two type-level enums, [`PinId`] and
 //! [`PinMode`].
 //!
-//! A `PinId` identifies a pin by it's group (A, B, C or D) and pin number. Each
+//! A `PinId` identifies a pin by it's group (BANK0 or QSPI) and pin number. Each
 //! `PinId` instance is named according to its datasheet identifier, e.g.
 //! [`Gpio0`](`bank0::Gpio0`).
 //!
diff --git a/rp2040-hal/src/gpio/reg.rs b/rp2040-hal/src/gpio/reg.rs
index 19aa439..aae57d9 100644
--- a/rp2040-hal/src/gpio/reg.rs
+++ b/rp2040-hal/src/gpio/reg.rs
@@ -81,7 +81,7 @@ impl From<DynPinMode> for ModeFields {
                     Uart => 2,
                     I2C => 3,
                     Pwm => 4,
-                    // Pio => 5
+                    // SIO is 5, but isn't an alternate function but is instead for using the pin as GPIO
                     Pio0 => 6,
                     Pio1 => 7,
                     Clock => 8,