alex/rp-hal-boards
1
0
Fork 0
mirror of https://github.com/italicsjenga/rp-hal-boards.git synced 2024-12-23 20:51:31 +11:00
Code Issues Packages Projects Releases Wiki Activity

Fix UART init code

Browse source 
Set uartlcr_h before enabling the UART.
Writing uartlcr_h while the UART is enabled is forbidden by the datasheet.

Details can be found here:
https://developer.arm.com/documentation/ddi0183/g/programmers-model/register-descriptions/line-control-register--uartlcr-h?lang=en
(As referenced from the Datasheet)
This commit is contained in:
Jan Niehusmann 2021-10-29 21:02:01 +00:00 committed by 9names
parent 73431a847b
commit b1dc9aec8c
1 changed files with 6 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
rp2040-hal/src/uart.rs
View file

@ -221,6 +221,12 @@ impl<D: UartDevice> UartPeripheral<Disabled, D> {
let effective_baudrate = configure_baudrate(&mut device, &config.baudrate, &frequency)?;
device.uartlcr_h.write(|w| {
w.fen().set_bit();
set_format(w, &config.data_bits, &config.stop_bits, &config.parity);
w
});
// Enable the UART, both TX and RX
device.uartcr.write(|w| {
w.uarten().set_bit();
@ -229,13 +235,6 @@ impl<D: UartDevice> UartPeripheral<Disabled, D> {
w
});
device.uartlcr_h.write(|w| {
w.fen().set_bit();
set_format(w, &config.data_bits, &config.stop_bits, &config.parity);
w
});
device.uartdmacr.write(|w| {
w.txdmae().set_bit();
w.rxdmae().set_bit();