2019-01-10 23:04:42 +11:00
|
|
|
#define _POSIX_C_SOURCE 200809L
|
2019-08-16 09:48:17 +10:00
|
|
|
#include <float.h>
|
2019-01-10 23:04:42 +11:00
|
|
|
#include <wlr/types/wlr_cursor.h>
|
input/tablet: add seatop_down entry for tablet input
Currently, when tablet input exits a window during an implicit grab, it
passes focus to another window.
For instance, this is problematic when trying to drag a scrollbar, and
exiting the window — the scrollbar motion stops. Additionally,
without `focus_follows_mouse no`, the tablet passes focus to whatever
surface it goes over regardless of if there is an active implicit.
If the tablet is over a surface that does not bind tablet handlers, sway
will fall back to pointer emulation, and all of this works fine. It
probably should have consistent behavior between emulated and
not-emulated input, though.
This commit adds a condition for entering seatop_down when a tablet's
tool tip goes down, and exiting when it goes up. Since events won't be
routed through seatop_default, this prevents windows losing focus during
implicit grabs.
Closes #5302.
2020-05-05 07:34:28 +10:00
|
|
|
#include <wlr/types/wlr_tablet_v2.h>
|
2019-01-10 23:04:42 +11:00
|
|
|
#include "sway/input/cursor.h"
|
|
|
|
|
#include "sway/input/seat.h"
|
|
|
|
|
#include "sway/tree/view.h"
|
2021-02-08 12:03:01 +11:00
|
|
|
#include "sway/desktop/transaction.h"
|
Introduce default seatop
This introduces a `default` seat operation which is used when no mouse
buttons are being held. This means there is now always a seat operation
in progress. It allows us to separate `default` code from the standard
cursor management code.
The sway_seatop_impl struct has gained callbacks `axis`, `rebase` and
`end`, and lost callbacks `finish` and `abort`. `axis` and `rebase` are
only used by the default seatop. `end` is called when a seatop is being
replaced by another one and allows the seatop to free any resources,
though no seatop currently needs to do this. `finish` is no longer
required, as each seatop can gracefully finish in their `button`
callback. And `abort` is not needed, as calling `end` would achieve the
same thing. The struct has also gained a bool named allow_set_cursor
which allows the client to set a new cursor during `default` and `down`
seatops.
Seatops would previously store which button they were started with and
stop when that button was released. This behaviour is changed so that it
only ends once all buttons are released. So you can start a drag with
$mod+left, then click and hold right, release left and it'll continue
dragging while the right button is held.
The motion callback now accepts dx and dy. Most seatops don't use this
as they store the cursor position when the seatop is started and compare
it with the current cursor position. This approach doesn't make sense
for the default seatop though, hence why dx and dy are needed.
The pressed_buttons array has been moved from the sway_cursor struct to
the default seatop's data. This is only used for the default seatop to
check bindings. The total pressed button count remains in the
sway_cursor struct though, because all the other seatops check it to
know if they should end.
The `down` seatop no longer has a `moved` property. This was used to
track if the cursor moved and to recheck focus_follows_mouse, but seems
to work without it.
The logic for focus_follows_mouse has been refactored. As part of this
I've removed the call to wlr_seat_keyboard_has_grab as we don't appear
to use keyboard grabs.
The functions for handling relative motion, absolute motion and tool
axis have been changed. Previously the handler functions were
handle_cursor_motion, handle_cursor_motion_absolute and
handle_tool_axis. The latter two both called cursor_motion_absolute.
Both handle_cursor_motion and cursor_motion_absolute did very similar
things. These are now simplified into three handlers and a single common
function called cursor_motion. All three handlers call cursor_motion. As
cursor_motion works with relative distances, the absolute and tool axis
handlers convert them to relative first.
2019-03-16 18:47:39 +11:00
|
|
|
#include "log.h"
|
2019-01-10 23:04:42 +11:00
|
|
|
|
|
|
|
|
struct seatop_down_event {
|
|
|
|
|
struct sway_container *con;
|
|
|
|
|
double ref_lx, ref_ly; // cursor's x/y at start of op
|
|
|
|
|
double ref_con_lx, ref_con_ly; // container's x/y at start of op
|
|
|
|
|
};
|
|
|
|
|
|
2020-05-03 02:15:39 +10:00
|
|
|
static void handle_pointer_axis(struct sway_seat *seat,
|
2019-08-16 09:48:17 +10:00
|
|
|
struct wlr_event_pointer_axis *event) {
|
|
|
|
|
struct sway_input_device *input_device =
|
|
|
|
|
event->device ? event->device->data : NULL;
|
|
|
|
|
struct input_config *ic =
|
|
|
|
|
input_device ? input_device_get_config(input_device) : NULL;
|
|
|
|
|
float scroll_factor =
|
|
|
|
|
(ic == NULL || ic->scroll_factor == FLT_MIN) ? 1.0f : ic->scroll_factor;
|
|
|
|
|
|
|
|
|
|
wlr_seat_pointer_notify_axis(seat->wlr_seat, event->time_msec,
|
|
|
|
|
event->orientation, scroll_factor * event->delta,
|
|
|
|
|
round(scroll_factor * event->delta_discrete), event->source);
|
|
|
|
|
}
|
|
|
|
|
|
2019-03-16 10:18:54 +11:00
|
|
|
static void handle_button(struct sway_seat *seat, uint32_t time_msec,
|
|
|
|
|
struct wlr_input_device *device, uint32_t button,
|
|
|
|
|
enum wlr_button_state state) {
|
|
|
|
|
seat_pointer_notify_button(seat, time_msec, button, state);
|
Introduce default seatop
This introduces a `default` seat operation which is used when no mouse
buttons are being held. This means there is now always a seat operation
in progress. It allows us to separate `default` code from the standard
cursor management code.
The sway_seatop_impl struct has gained callbacks `axis`, `rebase` and
`end`, and lost callbacks `finish` and `abort`. `axis` and `rebase` are
only used by the default seatop. `end` is called when a seatop is being
replaced by another one and allows the seatop to free any resources,
though no seatop currently needs to do this. `finish` is no longer
required, as each seatop can gracefully finish in their `button`
callback. And `abort` is not needed, as calling `end` would achieve the
same thing. The struct has also gained a bool named allow_set_cursor
which allows the client to set a new cursor during `default` and `down`
seatops.
Seatops would previously store which button they were started with and
stop when that button was released. This behaviour is changed so that it
only ends once all buttons are released. So you can start a drag with
$mod+left, then click and hold right, release left and it'll continue
dragging while the right button is held.
The motion callback now accepts dx and dy. Most seatops don't use this
as they store the cursor position when the seatop is started and compare
it with the current cursor position. This approach doesn't make sense
for the default seatop though, hence why dx and dy are needed.
The pressed_buttons array has been moved from the sway_cursor struct to
the default seatop's data. This is only used for the default seatop to
check bindings. The total pressed button count remains in the
sway_cursor struct though, because all the other seatops check it to
know if they should end.
The `down` seatop no longer has a `moved` property. This was used to
track if the cursor moved and to recheck focus_follows_mouse, but seems
to work without it.
The logic for focus_follows_mouse has been refactored. As part of this
I've removed the call to wlr_seat_keyboard_has_grab as we don't appear
to use keyboard grabs.
The functions for handling relative motion, absolute motion and tool
axis have been changed. Previously the handler functions were
handle_cursor_motion, handle_cursor_motion_absolute and
handle_tool_axis. The latter two both called cursor_motion_absolute.
Both handle_cursor_motion and cursor_motion_absolute did very similar
things. These are now simplified into three handlers and a single common
function called cursor_motion. All three handlers call cursor_motion. As
cursor_motion works with relative distances, the absolute and tool axis
handlers convert them to relative first.
2019-03-16 18:47:39 +11:00
|
|
|
|
|
|
|
|
if (seat->cursor->pressed_button_count == 0) {
|
|
|
|
|
seatop_begin_default(seat);
|
|
|
|
|
}
|
2019-03-16 10:18:54 +11:00
|
|
|
}
|
|
|
|
|
|
2020-11-01 08:56:21 +11:00
|
|
|
static void handle_pointer_motion(struct sway_seat *seat, uint32_t time_msec) {
|
2019-01-10 23:04:42 +11:00
|
|
|
struct seatop_down_event *e = seat->seatop_data;
|
|
|
|
|
struct sway_container *con = e->con;
|
|
|
|
|
if (seat_is_input_allowed(seat, con->view->surface)) {
|
|
|
|
|
double moved_x = seat->cursor->cursor->x - e->ref_lx;
|
|
|
|
|
double moved_y = seat->cursor->cursor->y - e->ref_ly;
|
|
|
|
|
double sx = e->ref_con_lx + moved_x;
|
|
|
|
|
double sy = e->ref_con_ly + moved_y;
|
|
|
|
|
wlr_seat_pointer_notify_motion(seat->wlr_seat, time_msec, sx, sy);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
input/tablet: add seatop_down entry for tablet input
Currently, when tablet input exits a window during an implicit grab, it
passes focus to another window.
For instance, this is problematic when trying to drag a scrollbar, and
exiting the window — the scrollbar motion stops. Additionally,
without `focus_follows_mouse no`, the tablet passes focus to whatever
surface it goes over regardless of if there is an active implicit.
If the tablet is over a surface that does not bind tablet handlers, sway
will fall back to pointer emulation, and all of this works fine. It
probably should have consistent behavior between emulated and
not-emulated input, though.
This commit adds a condition for entering seatop_down when a tablet's
tool tip goes down, and exiting when it goes up. Since events won't be
routed through seatop_default, this prevents windows losing focus during
implicit grabs.
Closes #5302.
2020-05-05 07:34:28 +10:00
|
|
|
static void handle_tablet_tool_tip(struct sway_seat *seat,
|
|
|
|
|
struct sway_tablet_tool *tool, uint32_t time_msec,
|
|
|
|
|
enum wlr_tablet_tool_tip_state state) {
|
|
|
|
|
if (state == WLR_TABLET_TOOL_TIP_UP) {
|
2020-06-04 14:31:19 +10:00
|
|
|
wlr_tablet_v2_tablet_tool_notify_up(tool->tablet_v2_tool);
|
input/tablet: add seatop_down entry for tablet input
Currently, when tablet input exits a window during an implicit grab, it
passes focus to another window.
For instance, this is problematic when trying to drag a scrollbar, and
exiting the window — the scrollbar motion stops. Additionally,
without `focus_follows_mouse no`, the tablet passes focus to whatever
surface it goes over regardless of if there is an active implicit.
If the tablet is over a surface that does not bind tablet handlers, sway
will fall back to pointer emulation, and all of this works fine. It
probably should have consistent behavior between emulated and
not-emulated input, though.
This commit adds a condition for entering seatop_down when a tablet's
tool tip goes down, and exiting when it goes up. Since events won't be
routed through seatop_default, this prevents windows losing focus during
implicit grabs.
Closes #5302.
2020-05-05 07:34:28 +10:00
|
|
|
seatop_begin_default(seat);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static void handle_tablet_tool_motion(struct sway_seat *seat,
|
2020-11-01 08:56:21 +11:00
|
|
|
struct sway_tablet_tool *tool, uint32_t time_msec) {
|
input/tablet: add seatop_down entry for tablet input
Currently, when tablet input exits a window during an implicit grab, it
passes focus to another window.
For instance, this is problematic when trying to drag a scrollbar, and
exiting the window — the scrollbar motion stops. Additionally,
without `focus_follows_mouse no`, the tablet passes focus to whatever
surface it goes over regardless of if there is an active implicit.
If the tablet is over a surface that does not bind tablet handlers, sway
will fall back to pointer emulation, and all of this works fine. It
probably should have consistent behavior between emulated and
not-emulated input, though.
This commit adds a condition for entering seatop_down when a tablet's
tool tip goes down, and exiting when it goes up. Since events won't be
routed through seatop_default, this prevents windows losing focus during
implicit grabs.
Closes #5302.
2020-05-05 07:34:28 +10:00
|
|
|
struct seatop_down_event *e = seat->seatop_data;
|
|
|
|
|
struct sway_container *con = e->con;
|
|
|
|
|
if (seat_is_input_allowed(seat, con->view->surface)) {
|
|
|
|
|
double moved_x = seat->cursor->cursor->x - e->ref_lx;
|
|
|
|
|
double moved_y = seat->cursor->cursor->y - e->ref_ly;
|
|
|
|
|
double sx = e->ref_con_lx + moved_x;
|
|
|
|
|
double sy = e->ref_con_ly + moved_y;
|
|
|
|
|
wlr_tablet_v2_tablet_tool_notify_motion(tool->tablet_v2_tool, sx, sy);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2019-01-10 23:04:42 +11:00
|
|
|
static void handle_unref(struct sway_seat *seat, struct sway_container *con) {
|
|
|
|
|
struct seatop_down_event *e = seat->seatop_data;
|
|
|
|
|
if (e->con == con) {
|
Introduce default seatop
This introduces a `default` seat operation which is used when no mouse
buttons are being held. This means there is now always a seat operation
in progress. It allows us to separate `default` code from the standard
cursor management code.
The sway_seatop_impl struct has gained callbacks `axis`, `rebase` and
`end`, and lost callbacks `finish` and `abort`. `axis` and `rebase` are
only used by the default seatop. `end` is called when a seatop is being
replaced by another one and allows the seatop to free any resources,
though no seatop currently needs to do this. `finish` is no longer
required, as each seatop can gracefully finish in their `button`
callback. And `abort` is not needed, as calling `end` would achieve the
same thing. The struct has also gained a bool named allow_set_cursor
which allows the client to set a new cursor during `default` and `down`
seatops.
Seatops would previously store which button they were started with and
stop when that button was released. This behaviour is changed so that it
only ends once all buttons are released. So you can start a drag with
$mod+left, then click and hold right, release left and it'll continue
dragging while the right button is held.
The motion callback now accepts dx and dy. Most seatops don't use this
as they store the cursor position when the seatop is started and compare
it with the current cursor position. This approach doesn't make sense
for the default seatop though, hence why dx and dy are needed.
The pressed_buttons array has been moved from the sway_cursor struct to
the default seatop's data. This is only used for the default seatop to
check bindings. The total pressed button count remains in the
sway_cursor struct though, because all the other seatops check it to
know if they should end.
The `down` seatop no longer has a `moved` property. This was used to
track if the cursor moved and to recheck focus_follows_mouse, but seems
to work without it.
The logic for focus_follows_mouse has been refactored. As part of this
I've removed the call to wlr_seat_keyboard_has_grab as we don't appear
to use keyboard grabs.
The functions for handling relative motion, absolute motion and tool
axis have been changed. Previously the handler functions were
handle_cursor_motion, handle_cursor_motion_absolute and
handle_tool_axis. The latter two both called cursor_motion_absolute.
Both handle_cursor_motion and cursor_motion_absolute did very similar
things. These are now simplified into three handlers and a single common
function called cursor_motion. All three handlers call cursor_motion. As
cursor_motion works with relative distances, the absolute and tool axis
handlers convert them to relative first.
2019-03-16 18:47:39 +11:00
|
|
|
seatop_begin_default(seat);
|
2019-01-10 23:04:42 +11:00
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
static const struct sway_seatop_impl seatop_impl = {
|
2019-03-16 10:18:54 +11:00
|
|
|
.button = handle_button,
|
2020-05-03 02:15:39 +10:00
|
|
|
.pointer_motion = handle_pointer_motion,
|
|
|
|
|
.pointer_axis = handle_pointer_axis,
|
input/tablet: add seatop_down entry for tablet input
Currently, when tablet input exits a window during an implicit grab, it
passes focus to another window.
For instance, this is problematic when trying to drag a scrollbar, and
exiting the window — the scrollbar motion stops. Additionally,
without `focus_follows_mouse no`, the tablet passes focus to whatever
surface it goes over regardless of if there is an active implicit.
If the tablet is over a surface that does not bind tablet handlers, sway
will fall back to pointer emulation, and all of this works fine. It
probably should have consistent behavior between emulated and
not-emulated input, though.
This commit adds a condition for entering seatop_down when a tablet's
tool tip goes down, and exiting when it goes up. Since events won't be
routed through seatop_default, this prevents windows losing focus during
implicit grabs.
Closes #5302.
2020-05-05 07:34:28 +10:00
|
|
|
.tablet_tool_tip = handle_tablet_tool_tip,
|
|
|
|
|
.tablet_tool_motion = handle_tablet_tool_motion,
|
2019-01-10 23:04:42 +11:00
|
|
|
.unref = handle_unref,
|
Introduce default seatop
This introduces a `default` seat operation which is used when no mouse
buttons are being held. This means there is now always a seat operation
in progress. It allows us to separate `default` code from the standard
cursor management code.
The sway_seatop_impl struct has gained callbacks `axis`, `rebase` and
`end`, and lost callbacks `finish` and `abort`. `axis` and `rebase` are
only used by the default seatop. `end` is called when a seatop is being
replaced by another one and allows the seatop to free any resources,
though no seatop currently needs to do this. `finish` is no longer
required, as each seatop can gracefully finish in their `button`
callback. And `abort` is not needed, as calling `end` would achieve the
same thing. The struct has also gained a bool named allow_set_cursor
which allows the client to set a new cursor during `default` and `down`
seatops.
Seatops would previously store which button they were started with and
stop when that button was released. This behaviour is changed so that it
only ends once all buttons are released. So you can start a drag with
$mod+left, then click and hold right, release left and it'll continue
dragging while the right button is held.
The motion callback now accepts dx and dy. Most seatops don't use this
as they store the cursor position when the seatop is started and compare
it with the current cursor position. This approach doesn't make sense
for the default seatop though, hence why dx and dy are needed.
The pressed_buttons array has been moved from the sway_cursor struct to
the default seatop's data. This is only used for the default seatop to
check bindings. The total pressed button count remains in the
sway_cursor struct though, because all the other seatops check it to
know if they should end.
The `down` seatop no longer has a `moved` property. This was used to
track if the cursor moved and to recheck focus_follows_mouse, but seems
to work without it.
The logic for focus_follows_mouse has been refactored. As part of this
I've removed the call to wlr_seat_keyboard_has_grab as we don't appear
to use keyboard grabs.
The functions for handling relative motion, absolute motion and tool
axis have been changed. Previously the handler functions were
handle_cursor_motion, handle_cursor_motion_absolute and
handle_tool_axis. The latter two both called cursor_motion_absolute.
Both handle_cursor_motion and cursor_motion_absolute did very similar
things. These are now simplified into three handlers and a single common
function called cursor_motion. All three handlers call cursor_motion. As
cursor_motion works with relative distances, the absolute and tool axis
handlers convert them to relative first.
2019-03-16 18:47:39 +11:00
|
|
|
.allow_set_cursor = true,
|
2019-01-10 23:04:42 +11:00
|
|
|
};
|
|
|
|
|
|
2019-03-01 05:22:47 +11:00
|
|
|
void seatop_begin_down(struct sway_seat *seat, struct sway_container *con,
|
2021-08-05 14:26:34 +10:00
|
|
|
uint32_t time_msec, double sx, double sy) {
|
Introduce default seatop
This introduces a `default` seat operation which is used when no mouse
buttons are being held. This means there is now always a seat operation
in progress. It allows us to separate `default` code from the standard
cursor management code.
The sway_seatop_impl struct has gained callbacks `axis`, `rebase` and
`end`, and lost callbacks `finish` and `abort`. `axis` and `rebase` are
only used by the default seatop. `end` is called when a seatop is being
replaced by another one and allows the seatop to free any resources,
though no seatop currently needs to do this. `finish` is no longer
required, as each seatop can gracefully finish in their `button`
callback. And `abort` is not needed, as calling `end` would achieve the
same thing. The struct has also gained a bool named allow_set_cursor
which allows the client to set a new cursor during `default` and `down`
seatops.
Seatops would previously store which button they were started with and
stop when that button was released. This behaviour is changed so that it
only ends once all buttons are released. So you can start a drag with
$mod+left, then click and hold right, release left and it'll continue
dragging while the right button is held.
The motion callback now accepts dx and dy. Most seatops don't use this
as they store the cursor position when the seatop is started and compare
it with the current cursor position. This approach doesn't make sense
for the default seatop though, hence why dx and dy are needed.
The pressed_buttons array has been moved from the sway_cursor struct to
the default seatop's data. This is only used for the default seatop to
check bindings. The total pressed button count remains in the
sway_cursor struct though, because all the other seatops check it to
know if they should end.
The `down` seatop no longer has a `moved` property. This was used to
track if the cursor moved and to recheck focus_follows_mouse, but seems
to work without it.
The logic for focus_follows_mouse has been refactored. As part of this
I've removed the call to wlr_seat_keyboard_has_grab as we don't appear
to use keyboard grabs.
The functions for handling relative motion, absolute motion and tool
axis have been changed. Previously the handler functions were
handle_cursor_motion, handle_cursor_motion_absolute and
handle_tool_axis. The latter two both called cursor_motion_absolute.
Both handle_cursor_motion and cursor_motion_absolute did very similar
things. These are now simplified into three handlers and a single common
function called cursor_motion. All three handlers call cursor_motion. As
cursor_motion works with relative distances, the absolute and tool axis
handlers convert them to relative first.
2019-03-16 18:47:39 +11:00
|
|
|
seatop_end(seat);
|
2019-01-10 23:04:42 +11:00
|
|
|
|
|
|
|
|
struct seatop_down_event *e =
|
|
|
|
|
calloc(1, sizeof(struct seatop_down_event));
|
|
|
|
|
if (!e) {
|
|
|
|
|
return;
|
|
|
|
|
}
|
|
|
|
|
e->con = con;
|
|
|
|
|
e->ref_lx = seat->cursor->cursor->x;
|
|
|
|
|
e->ref_ly = seat->cursor->cursor->y;
|
|
|
|
|
e->ref_con_lx = sx;
|
|
|
|
|
e->ref_con_ly = sy;
|
|
|
|
|
|
|
|
|
|
seat->seatop_impl = &seatop_impl;
|
|
|
|
|
seat->seatop_data = e;
|
2019-01-16 08:38:31 +11:00
|
|
|
|
|
|
|
|
container_raise_floating(con);
|
2021-02-08 12:03:01 +11:00
|
|
|
transaction_commit_dirty();
|
2019-01-10 23:04:42 +11:00
|
|
|
}
|
