alex/swayfx
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

Smart borders fix: always show borders for floating containers

Browse source 
Currently, in view_autoconfigure, the only condition for show_border
is !view_is_only_visible. view_is_only_visible does not cross the
boundary between the workspace's tiling and floating lists and does not
differentiate between them.

The result is, that in a workspace with zero or more tiling containers
and a single floating container, the floating container will lose its
borders as soon as it is split, provided that a only one view is visible
within the floating container.

Fixed by adjusting the condition for show_borders.
This commit is contained in:
Dimitris Triantafyllidis 2020-10-25 23:20:19 +02:00 committed by Tudor Brindus
parent 13a67da614
commit 0cb9282aee
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
sway/tree/view.c
View file

@ -280,7 +280,8 @@ void view_autoconfigure(struct sway_view *view) {
(config->hide_edge_borders_smart == ESMART_NO_GAPS && (config->hide_edge_borders_smart == ESMART_NO_GAPS &&
!gaps_to_edge(view)); !gaps_to_edge(view));
if (smart) { if (smart) {
bool show_border = !view_is_only_visible(view); bool show_border = container_is_floating_or_child(con) ||
!view_is_only_visible(view);
con->border_left &= show_border; con->border_left &= show_border;
con->border_right &= show_border; con->border_right &= show_border;
con->border_top &= show_border; con->border_top &= show_border;