alex/swayfx
1
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

xdg_shell: allow views to change geometry anytime

Browse source 
Currently, when sway sends a configure with some geometry and the
client responds with a different geometry in a commit that acks that
configure, sway ignores the new size. Sway applies the surface
geometry it had requested to the container, not what was actually
committed, in the following transaction.

This change allows any client commit to change its surface geometry,
even if it is a response to a configure event.
This commit is contained in:
Ronan Pigott 2020-11-13 14:05:18 -07:00 committed by Simon Ser
parent f1afef5533
commit 32b93ef6ea
1 changed files with 18 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
sway/desktop/xdg_shell.c
View file

@ -284,28 +284,27 @@ static void handle_commit(struct wl_listener *listener, void *data) {
struct sway_view *view = &xdg_shell_view->view; struct sway_view *view = &xdg_shell_view->view;
struct wlr_xdg_surface *xdg_surface = view->wlr_xdg_surface; struct wlr_xdg_surface *xdg_surface = view->wlr_xdg_surface;
if (view->container->node.instruction) {
wlr_xdg_surface_get_geometry(xdg_surface, &view->geometry);
transaction_notify_view_ready_by_serial(view,
xdg_surface->configure_serial);
} else {
struct wlr_box new_geo; struct wlr_box new_geo;
wlr_xdg_surface_get_geometry(xdg_surface, &new_geo); wlr_xdg_surface_get_geometry(xdg_surface, &new_geo);
bool new_size = new_geo.width != view->geometry.width ||
if ((new_geo.width != view->geometry.width ||
new_geo.height != view->geometry.height || new_geo.height != view->geometry.height ||
new_geo.x != view->geometry.x || new_geo.x != view->geometry.x ||
new_geo.y != view->geometry.y)) { new_geo.y != view->geometry.y;
if (new_size) {
// The view has unexpectedly sent a new size // The view has unexpectedly sent a new size
desktop_damage_view(view); desktop_damage_view(view);
view_update_size(view, new_geo.width, new_geo.height); view_update_size(view, new_geo.width, new_geo.height);
memcpy(&view->geometry, &new_geo, sizeof(struct wlr_box)); memcpy(&view->geometry, &new_geo, sizeof(struct wlr_box));
desktop_damage_view(view); desktop_damage_view(view);
transaction_commit_dirty(); transaction_commit_dirty();
transaction_notify_view_ready_immediately(view);
} else {
memcpy(&view->geometry, &new_geo, sizeof(struct wlr_box));
} }
if (view->container->node.instruction) {
transaction_notify_view_ready_by_serial(view,
xdg_surface->configure_serial);
} else if (new_size) {
transaction_notify_view_ready_immediately(view);
} }
view_damage_from(view); view_damage_from(view);