Fix swaybar axis event logic
Uses 'visible' instead of 'focused', since we may scroll on a bar which isn't the focused output. We can't use "next_on_output" or "prev_on_output" to implement this, because it only modify the focused output. So scrolling on an unfocused output will affect the incorrect one. We just use the "workspace name" command instead.
This commit is contained in:
parent
72149111a5
commit
4dfbc3160c
|
@ -156,31 +156,56 @@ static void wl_pointer_axis(void *data, struct wl_pointer *wl_pointer,
|
||||||
if (!sway_assert(output, "axis with no active output")) {
|
if (!sway_assert(output, "axis with no active output")) {
|
||||||
return;
|
return;
|
||||||
}
|
}
|
||||||
|
|
||||||
double amt = wl_fixed_to_double(value);
|
double amt = wl_fixed_to_double(value);
|
||||||
if (!bar->config->wrap_scroll) {
|
if (amt == 0.0) {
|
||||||
int i = 0;
|
return;
|
||||||
struct swaybar_workspace *ws = NULL;
|
|
||||||
wl_list_for_each(ws, &output->workspaces, link) {
|
|
||||||
if (ws->focused) {
|
|
||||||
break;
|
|
||||||
}
|
|
||||||
++i;
|
|
||||||
}
|
|
||||||
int len = wl_list_length(&output->workspaces);
|
|
||||||
if (!sway_assert(i != len, "axis with null workspace")) {
|
|
||||||
return;
|
|
||||||
}
|
|
||||||
if (i == 0 && amt > 0) {
|
|
||||||
return; // Do not wrap
|
|
||||||
}
|
|
||||||
if (i == len - 1 && amt < 0) {
|
|
||||||
return; // Do not wrap
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
|
|
||||||
const char *workspace_name =
|
struct swaybar_workspace *first = NULL;
|
||||||
amt < 0 ? "prev_on_output" : "next_on_output";
|
struct swaybar_workspace *active = NULL;
|
||||||
ipc_send_workspace_command(bar, workspace_name);
|
struct swaybar_workspace *last;
|
||||||
|
|
||||||
|
struct swaybar_workspace *iter;
|
||||||
|
wl_list_for_each(iter, &output->workspaces, link) {
|
||||||
|
if (!first) {
|
||||||
|
first = iter;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (iter->visible) {
|
||||||
|
active = iter;
|
||||||
|
}
|
||||||
|
|
||||||
|
last = iter;
|
||||||
|
}
|
||||||
|
|
||||||
|
if (!sway_assert(active, "axis with null workspace")) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
|
||||||
|
struct swaybar_workspace *new;
|
||||||
|
|
||||||
|
if (amt > 0.0) {
|
||||||
|
if (active == first) {
|
||||||
|
if (!bar->config->wrap_scroll) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
new = last;
|
||||||
|
}
|
||||||
|
|
||||||
|
new = wl_container_of(active->link.prev, new, link);
|
||||||
|
} else {
|
||||||
|
if (active == last) {
|
||||||
|
if (!bar->config->wrap_scroll) {
|
||||||
|
return;
|
||||||
|
}
|
||||||
|
new = first;
|
||||||
|
}
|
||||||
|
|
||||||
|
new = wl_container_of(active->link.next, new, link);
|
||||||
|
}
|
||||||
|
|
||||||
|
ipc_send_workspace_command(bar, new->name);
|
||||||
}
|
}
|
||||||
|
|
||||||
static void wl_pointer_frame(void *data, struct wl_pointer *wl_pointer) {
|
static void wl_pointer_frame(void *data, struct wl_pointer *wl_pointer) {
|
||||||
|
|
Loading…
Reference in a new issue